From: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V7] package/nvme: new package
Date: Thu, 11 Feb 2016 16:48:20 +0530 [thread overview]
Message-ID: <56BC6DFC.3020403@linux.vnet.ibm.com> (raw)
In-Reply-To: <56BBA4C0.4020304@mind.be>
Hi Arnout,
Thanks for the review comments
updated all your comments and sent new version of Patch.
On 02/11/2016 02:29 AM, Arnout Vandecappelle wrote:
> diff --git a/package/nvme/0001-NVME-Makefile-cleanup.patch b/package/nvme/0001-NVME-Makefile-cleanup.patch
> new file mode 100644
> index 0000000..74beac9
> --- /dev/null
> +++ b/package/nvme/0001-NVME-Makefile-cleanup.patch
> @@ -0,0 +1,25 @@
> +From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
> +From: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
> +Date: Mon, 18 Jan 2016 12:40:00 +0530
> +Subject: [PATCH V2] NVME Makefile update
> +
> +Makefile cleanup: remove -Werror flag in CFLAGS
> +
> +Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
> +---
> + Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile b/Makefile
> +index d0c0ce4..003928b 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -1,4 +1,4 @@
> +-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
> ++CFLAGS += -std=gnu99 -O2 -g -Wall
> This patch doesn't apply, the CFLAGS line looks completely different. Have you
> tested your patch before submitting?
yes I have tested my patch and it will apply fine.
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160211/997ead13/attachment.html>
next prev parent reply other threads:[~2016-02-11 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 5:36 [Buildroot] [PATCH V7] package/nvme: new package Mamatha Inamdar
2016-02-04 6:08 ` Mamatha Inamdar
2016-02-10 15:07 ` Mamatha Inamdar
2016-02-10 20:59 ` Arnout Vandecappelle
2016-02-11 11:18 ` Mamatha Inamdar [this message]
2016-02-11 16:35 ` Mamatha Inamdar
2016-02-12 10:43 ` Mamatha Inamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC6DFC.3020403@linux.vnet.ibm.com \
--to=mamatha4@linux.vnet.ibm.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox