From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] libcapn : new package
Date: Wed, 17 Feb 2016 23:22:38 +0100 [thread overview]
Message-ID: <56C4F2AE.7020806@mind.be> (raw)
In-Reply-To: <20160217221900.1ee0f081@free-electrons.com>
On 17-02-16 22:19, Thomas Petazzoni wrote:
> Hello Johan,
>
> Thanks for this patch! See some comments below.
>
> On Wed, 17 Feb 2016 19:04:06 +0100, Sagaert Johan wrote:
[snip]
>> +LIBCAPN_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release \
>
> This is already passed by the CMake package infrastructure, so it is
> useless (and wrong when BR2_ENABLE_DEBUG is enabled).
>
>> + -DAPN_HAVE_GLIBC_STRERROR_R=OFF \
>> + -DAPN_HAVE_POSIX_STRERROR_R=OFF \
>> + -DAPN_HAVE_GLIBC_STRERROR_R__TRYRUN_OUTPUT=OFF \
>> + -DAPN_HAVE_POSIX_STRERROR_R__TRYRUN_OUTPUT=OFF
>
> I'm pretty sure those could be set to "ON" when glibc is used, but I
> guess OFF is a sane default, and if it builds and works this way, fair
> enough.
As I explained in the original discussion I had with Johan: even on glibc, the
POSIX version of strerror_r will be used because the CMakeLists.txt also adds
-D_POSIX_C_SOURCE=200112L and doesn't add -D_GNU_SOURCE.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-17 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:04 [Buildroot] [PATCH v2 1/1] libcapn : new package Sagaert Johan
2016-02-17 21:19 ` Thomas Petazzoni
2016-02-17 22:22 ` Arnout Vandecappelle [this message]
2016-02-17 23:12 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4F2AE.7020806@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox