From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/7] package/cairo: add optional support for lzo
Date: Sun, 21 Feb 2016 13:48:34 +0100 [thread overview]
Message-ID: <56C9B222.7040703@mind.be> (raw)
In-Reply-To: <1456051888-2047-3-git-send-email-bernd.kuhls@t-online.de>
On 02/21/16 11:51, Bernd Kuhls wrote:
> When lzo was compiled before, cairo will use it as optional dependency:
>
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/cairo-sphinx | grep NEEDED | sort
> [...]
> 0x0000000000000001 (NEEDED) Shared library: [liblzo2.so.2]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/cairo/cairo.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
> index 205250d..49cf921 100644
> --- a/package/cairo/cairo.mk
> +++ b/package/cairo/cairo.mk
> @@ -142,6 +142,9 @@ endif
>
> ifeq ($(BR2_PACKAGE_CAIRO_TEE),y)
> CAIRO_CONF_OPTS += --enable-tee
> +ifeq ($(BR2_PACKAGE_LZO),y)
> +CAIRO_DEPENDENCIES += lzo
> +endif
I don't see why this would only be in the --enable-tee case.
In fact, it looks like it is rather bound to the script option than to the tee
option (at least, when looking at the source). But just to be safe I'd put this
dependency outside of any conditions.
Regards,
Arnout
> else
> CAIRO_CONF_OPTS += --disable-tee
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-21 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 10:51 [Buildroot] [PATCH 1/7] package/cifs-utils: add optional support for keyutils Bernd Kuhls
2016-02-21 10:51 ` [Buildroot] [PATCH 2/7] package/imagemagick: add optional support for lcms2 Bernd Kuhls
2016-02-21 13:51 ` Thomas Petazzoni
2016-02-21 10:51 ` [Buildroot] [PATCH 3/7] package/cairo: add optional support for lzo Bernd Kuhls
2016-02-21 12:48 ` Arnout Vandecappelle [this message]
2016-02-21 13:51 ` Thomas Petazzoni
2016-02-21 10:51 ` [Buildroot] [PATCH 4/7] package/libfm: add optional support for libexif Bernd Kuhls
2016-02-21 13:51 ` Thomas Petazzoni
2016-02-21 10:51 ` [Buildroot] [PATCH 5/7] package/dvdauthor: add optional support for libfribidi Bernd Kuhls
2016-02-21 13:51 ` Thomas Petazzoni
2016-02-21 10:51 ` [Buildroot] [PATCH 6/7] package/sdl_sound: add optional support for libmodplug Bernd Kuhls
2016-02-21 13:52 ` Thomas Petazzoni
2016-02-21 10:51 ` [Buildroot] [PATCH 7/7] package/sdl_sound: FLAC support depends on libogg Bernd Kuhls
2016-02-21 13:52 ` Thomas Petazzoni
2016-02-21 13:45 ` [Buildroot] [PATCH 1/7] package/cifs-utils: add optional support for keyutils Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C9B222.7040703@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox