From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/util-linux: remove patch for uClibc support
Date: Sun, 21 Feb 2016 18:33:00 +0100 [thread overview]
Message-ID: <56C9F4CC.7050102@gmail.com> (raw)
In-Reply-To: <20160221182009.4ad78b2f@free-electrons.com>
Thomas,
Le 21/02/2016 18:20, Thomas Petazzoni a ?crit :
> Hello,
>
> On Sun, 21 Feb 2016 17:34:05 +0100, Romain Naour wrote:
>
>>> Though it looks like this smartcols library also uses fork(), so it
>>> anyway cannot work properly.
>>>
>>> Romain, it seems like your patch is not completely correct, so I've
>>> marked it as Rejected.
>>
>> Ok no problem, I probably didn't selected the good util-linux option... my bad.
>
> util-linux itself build fine. It's then if you try to link a program
> with libsmartcols.
>
> But on the other hand, libsmartcols uses fork(), which cannot be used
> on no-MMU platforms... So the fact that libsmartcols uses mkostemp()
> is maybe not that relevant.
So let's disable libsmartcols for no-MMU platforms and remove the patch :)
Best regards,
Romain
>
> Best regards,
>
> Thomas
>
prev parent reply other threads:[~2016-02-21 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 22:28 [Buildroot] [PATCH] package/util-linux: remove patch for uClibc support Romain Naour
2016-02-20 23:31 ` Arnout Vandecappelle
2016-02-21 14:10 ` Thomas Petazzoni
2016-02-21 16:34 ` Romain Naour
2016-02-21 17:20 ` Thomas Petazzoni
2016-02-21 17:33 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C9F4CC.7050102@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox