[Buildroot] [PATCH] procrank_linux: new package

[Arnout Vandecappelle <arnout@mind.be>]

On 02/23/16 16:54, gustavo.zacarias at free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>  package/Config.in                        |  3 +++
>  package/procrank_linux/Config.in         |  7 +++++++
>  package/procrank_linux/procrank_linux.mk | 21 +++++++++++++++++++++

 You forgot to add a hash file.

>  3 files changed, 31 insertions(+)
>  create mode 100644 package/procrank_linux/Config.in
>  create mode 100644 package/procrank_linux/procrank_linux.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 00132df..c1be419 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1595,6 +1595,9 @@ endif
>  	source "package/powerpc-utils/Config.in"
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/procps-ng/Config.in"
> +endif
> +	source "package/procrank_linux/Config.in"
> +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  	source "package/psmisc/Config.in"
>  endif
>  	source "package/pwgen/Config.in"
> diff --git a/package/procrank_linux/Config.in b/package/procrank_linux/Config.in
> new file mode 100644
> index 0000000..59d462b
> --- /dev/null
> +++ b/package/procrank_linux/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PROCRANK_LINUX
> +	bool "procrank_linux"
> +	help
> +	  procrank is a tool commonly used by Android platform
> +	  developers to find out how much memory is really being used.
> +
> +	  https://github.com/csimmonds/procrank_linux
> diff --git a/package/procrank_linux/procrank_linux.mk b/package/procrank_linux/procrank_linux.mk
> new file mode 100644
> index 0000000..7e74319
> --- /dev/null
> +++ b/package/procrank_linux/procrank_linux.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# procrank_linux
> +#
> +################################################################################
> +
> +PROCRANK_LINUX_VERSION = 21c30ab4514a5b15ac6e813e21bee0d3d714cb08
> +PROCRANK_LINUX_SITE = $(call github,csimmonds,procrank_linux,$(PROCRANK_LINUX_VERSION))
> +PROCRANK_LINUX_LICENSE = Apache-2.0
> +PROCRANK_LINUX_LICENSE_FILES = NOTICE

 Check. There's a Makefile licensed GPLv2+ but I guess that's not relevant.

> +
> +define PROCRANK_LINUX_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CROSS_COMPILE="$(TARGET_CROSS)"

 What a horrible Makefile... There is no way to pass CFLAGS and LDFLAGS.
Fortunately, with the toolchain wrapper, this shouldn't be a problem anymore.
Well, except for LDFLAGS. This _is_ going to be a problem on e.g. Blackfin FLAT.
I guess a patch adding CFLAGS and LDFLAGS to the Makefiles would be upstreamable?

 Regards,
 Arnout

> +endef
> +
> +define PROCRANK_LINUX_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/procrank \
> +		$(TARGET_DIR)/usr/bin/procrank
> +endef
> +
> +$(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF