Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt: script & webkit depend on BR2_TOOLCHAIN_HAS_SYNC_4
Date: Wed, 24 Feb 2016 22:09:55 +0100	[thread overview]
Message-ID: <56CE1C23.6040101@mind.be> (raw)
In-Reply-To: <1456316443-7087-1-git-send-email-gustavo@zacarias.com.ar>

On 02/24/16 13:20, Gustavo Zacarias wrote:
> They use __sync_add_and_fetch_4() and other 32-bit atomics, fixes:
> http://autobuild.buildroot.net/results/7ac/7acdbc54e26ad2ba4756512614192be0a086f563/
> 
> Also remove sparc from supported architectures since it won't grow
> atomics support magically.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout


> ---
>  package/qt/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index bf14724..1579b61 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -407,12 +407,13 @@ config BR2_PACKAGE_QT_NETWORK
>  
>  config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>  	bool
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	# see src/3rdparty/webkit/Source/JavaScriptCore/wtf/Platform.h
>  	# see http://lists.busybox.net/pipermail/buildroot/2014-November/112605.html
>  	default y if BR2_arc || BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
>  		BR2_microblazebe || BR2_mips || BR2_mipsel || \
>  		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
> -		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
> +		BR2_powerpc64 || BR2_powerpc64le || BR2_x86_64
>  	# The CodeSourcery SuperH toolchain fails to build Webkit,
>  	# with an assertion failure in binutils.
>  	default y if (BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb) && \
> @@ -454,12 +455,13 @@ config BR2_PACKAGE_QT_OPENSSL
>  
>  config BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT
>  	bool
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	# see http://lists.busybox.net/pipermail/buildroot/2014-November/112605.html
>  	default y if BR2_arc || BR2_arm || BR2_armeb || aarch64 || BR2_i386 || \
>  		BR2_microblazeel || BR2_microblazebe || BR2_mips || BR2_mipsel || \
>  		BR2_mips64 || BR2_mips64el || BR2_nios2 || BR2_powerpc || \
>  		BR2_powerpc64 || BR2_powerpc64le || BR2_sh4 || BR2_sh4eb || \
> -		BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64
> +		BR2_sh4a || BR2_sh4aeb || BR2_x86_64
>  
>  config BR2_PACKAGE_QT_SCRIPT
>  	bool "Script Module"
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  parent reply	other threads:[~2016-02-24 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 12:20 [Buildroot] [PATCH 1/2] qt: script & webkit depend on BR2_TOOLCHAIN_HAS_SYNC_4 Gustavo Zacarias
2016-02-24 12:20 ` [Buildroot] [PATCH 2/2] qt: properly enable script aarch64 support Gustavo Zacarias
2016-02-24 22:29   ` Peter Korsgaard
2016-02-24 21:09 ` Arnout Vandecappelle [this message]
2016-02-24 21:12   ` [Buildroot] [PATCH 1/2] qt: script & webkit depend on BR2_TOOLCHAIN_HAS_SYNC_4 Arnout Vandecappelle
2016-02-24 22:29 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CE1C23.6040101@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox