From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/mono: Fixing wrong MonoPosixHelper location
Date: Thu, 25 Feb 2016 00:09:19 +0100 [thread overview]
Message-ID: <56CE381F.503@mind.be> (raw)
In-Reply-To: <CA+TH9VkDB+PuPwp3RDOcC8Th=vRF+hYUBLZkdycnJ5hVEBnzqw@mail.gmail.com>
On 02/24/16 21:46, Angelo Compagnucci wrote:
> Dear Arnout Vandecappelle,
>
> 2016-02-24 21:34 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>:
>> On 02/23/16 23:29, Angelo Compagnucci wrote:
>>> Dear Arnout Vandecappelle,
>>>
>>> 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>:
>>>> On 02/23/16 22:50, Angelo Compagnucci wrote:
>>>>> * This patch solves installation problems with monoposixhelper
>>>>
>>>> This description should be better, e.g. taking part of the bug description.
>>>>
>>>> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path
>>>> and file may exist on my building machine, but not on the target.
>>>>
>>>> Fixes bug #8651.
>>>
>>> Have I to resend?
>>
>> Depends on the outcome of the discussion below.
[snip]
> I can assure the patch I submitted solves the problem. In mono
> upstream, developers did a refactor of that part and the patch I
> previously sent (for master) is simply wrong, cause the refactor
> already solves the problem. Indeed I closed the issue on mono github.
>
> As you said previously, mono has a really slow release process, with
> many months of delay, so I think we should stick with this latter
> patch I sent.
>
> When the new release 4.3.X will be out, I will promptly bump to that
> version and remove the unneeded patch.
OK, so:
- mono master is working;
- backporting the upstream patch is a bit of work;
- this simpler patch also works for us
Therefore:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
with the improved commit message mentioned above. Angelo, if you have a bit of
time, please do resend with the improved commit message and my ack.
As an aside, I searched for host-path references in the build result, and there
still is one in
/usr/lib/mono/gac/monodoc/1.0.0.0__0738eb9f132ed756/monodoc.dll.config
Care to take a look at that?
Regards,
Arnout
>
> Sincerely, Angelo
>
>>
>> Regards,
>> Arnout
>>
>> [snip]
>>
>> --
>> Arnout Vandecappelle arnout at mind be
>> Senior Embedded Software Architect +32-16-286500
>> Essensium/Mind http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-24 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 21:50 [Buildroot] [PATCH v3] package/mono: Fixing wrong MonoPosixHelper location Angelo Compagnucci
2016-02-23 22:19 ` Arnout Vandecappelle
2016-02-23 22:29 ` Angelo Compagnucci
2016-02-24 20:34 ` Arnout Vandecappelle
2016-02-24 20:46 ` Angelo Compagnucci
2016-02-24 23:09 ` Arnout Vandecappelle [this message]
2016-02-25 7:42 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CE381F.503@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox