Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/32] package/lz4: bump version to r131
Date: Fri, 26 Feb 2016 00:44:42 +0100	[thread overview]
Message-ID: <56CF91EA.6040300@mind.be> (raw)
In-Reply-To: <1456437341-19025-2-git-send-email-gabe@hashrabbit.co>

 Hi Gabe,

 I'm not going to review all of the series yet, just a few of them. The patches
which are pretty independent (like this one) you can resend individually. Only
when you resend the later ones you need to send the entire series.

On 02/25/16 22:55, Gabe Evans wrote:
> systemd v228 requires lz4 >= 125
> 
> Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
> ---
>  package/lz4/lz4.hash |  2 ++
>  package/lz4/lz4.mk   | 19 ++++++++++++-------
>  2 files changed, 14 insertions(+), 7 deletions(-)
>  create mode 100644 package/lz4/lz4.hash
> 
> diff --git a/package/lz4/lz4.hash b/package/lz4/lz4.hash
> new file mode 100644
> index 0000000..1281284
> --- /dev/null
> +++ b/package/lz4/lz4.hash
> @@ -0,0 +1,2 @@
> +# sha256 locally computed
> +sha256 9d4d00614d6b9dec3114b33d1224b6262b99ace24434c53487a0c8fd0b18cfed  lz4-r131.tar.gz
> diff --git a/package/lz4/lz4.mk b/package/lz4/lz4.mk
> index 38e10d8..dbb2221 100644
> --- a/package/lz4/lz4.mk
> +++ b/package/lz4/lz4.mk
> @@ -4,37 +4,42 @@
>  #
>  ################################################################################
>  
> -LZ4_VERSION = r123
> +LZ4_VERSION = r131
>  LZ4_SITE = $(call github,Cyan4973,lz4,$(LZ4_VERSION))
>  LZ4_INSTALL_STAGING = YES
>  LZ4_LICENSE = BSD-2c
>  LZ4_LICENSE_FILES = LICENSE
>  
> +LZ4_MAKE_OPTS = PREFIX=/usr

 I'd prefer to have

LZ4_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS) PREFIX=/usr
HOST_LZ4_MAKE_OPTS = $(HOST_CONFIGURE_OPTS) PREFIX=/usr

 However, is the PREFIX useful during the build? If it's only needed at install
time, then I would just pass it there, like we do with DESTDIR already.


 Regards,
 Arnout

> +
>  ifeq ($(BR2_STATIC_LIBS),y)
>  define LZ4_DISABLE_SHARED
> -	$(SED) '/SHARED/d' $(@D)/Makefile
> +	$(SED) '/SHARED/d' $(@D)/lib/Makefile
>  endef
>  LZ4_POST_PATCH_HOOKS += LZ4_DISABLE_SHARED
>  endif
>  
>  define HOST_LZ4_BUILD_CMDS
> -	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> +	$(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)
>  endef
>  
>  define HOST_LZ4_INSTALL_CMDS
> -	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(HOST_DIR)
> +	$(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(HOST_DIR) \
> +		install -C $(@D)
>  endef
>  
>  define LZ4_BUILD_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) liblz4
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)/lib
>  endef
>  
>  define LZ4_INSTALL_STAGING_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(STAGING_DIR)
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(STAGING_DIR) \
> +		install -C $(@D)
>  endef
>  
>  define LZ4_INSTALL_TARGET_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(TARGET_DIR)
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(TARGET_DIR) \
> +		install -C $(@D)/lib
>  endef
>  
>  $(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-02-25 23:44 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 21:55 [Buildroot] [PATCH 00/32] systemd feature selection Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 01/32] package/lz4: bump version to r131 Gabe Evans
2016-02-25 23:44   ` Arnout Vandecappelle [this message]
2016-02-25 23:57     ` Gabe Evans
2016-02-26  0:16       ` Arnout Vandecappelle
2016-02-29 21:40   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 02/32] package/systemd: remove BR2_PACKAGE_SYSTEMD_ALL_EXTRAS Gabe Evans
2016-02-25 23:52   ` Arnout Vandecappelle
2016-02-29 21:44   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 03/32] package/systemd: add --enable/disable-bzip2 Gabe Evans
2016-02-26  0:01   ` Arnout Vandecappelle
2016-02-29 21:48   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 04/32] package/systemd: add --enable/disable-lz4 Gabe Evans
2016-02-26  0:03   ` Arnout Vandecappelle
2016-02-29 21:48   ` Thomas Petazzoni
2016-02-29 22:02     ` Peter Korsgaard
2016-02-29 22:15       ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 05/32] package/systemd: add --enable/disable-zlib Gabe Evans
2016-02-26  0:05   ` Arnout Vandecappelle
2016-02-26  0:27     ` Gabe Evans
2016-02-29 21:48   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 06/32] package/systemd: add --enable/disable-libcurl Gabe Evans
2016-02-26  0:07   ` Arnout Vandecappelle
2016-02-29 21:48   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 07/32] package/systemd: explicitly --enable/disable-microhttpd Gabe Evans
2016-02-26  0:08   ` Arnout Vandecappelle
2016-02-29 21:48   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 08/32] package/systemd: remove networkd depends from timesyncd Gabe Evans
2016-02-26  0:10   ` Arnout Vandecappelle
2016-02-29 21:52     ` Thomas Petazzoni
2016-02-29 21:50   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 09/32] package/systemd: add support for specifying NTP servers Gabe Evans
2016-02-29 21:50   ` Thomas Petazzoni
2016-03-02 18:10     ` Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 10/32] package/systemd: add optional support for binfmt Gabe Evans
2016-02-29 21:55   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 11/32] package/systemd: add optional support for vconsole Gabe Evans
2016-02-29 21:56   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 12/32] package/systemd: add optional support for bootchart Gabe Evans
2016-02-29 21:56   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 13/32] package/systemd: add optional support for quotacheck Gabe Evans
2016-02-29 21:56   ` Thomas Petazzoni
2016-02-25 21:55 ` [Buildroot] [PATCH 14/32] package/systemd: add optional support for tmpfiles Gabe Evans
2016-02-29 21:56   ` Thomas Petazzoni
2016-03-01 22:00     ` Arnout Vandecappelle
2016-03-02 11:55       ` Maxime Hadjinlian
2016-03-02 18:05         ` Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 15/32] package/systemd: add optional support for sysusers Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 16/32] package/systemd: add optional support for firstboot Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 17/32] package/systemd: add optional support for random-seed Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 18/32] package/systemd: add optional support for backlight Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 19/32] package/systemd: add optional support for rfkill Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 20/32] package/systemd: add optional support for logind Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 21/32] package/systemd: add optional support for machined Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 22/32] package/systemd: add optional support for importd Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 23/32] package/systemd: add optional support for hostnamed Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 24/32] package/systemd: add optional support for timedated Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 25/32] package/systemd: add optional support for localed Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 26/32] package/systemd: add optional support for coredump Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 27/32] package/systemd: add optional support for polkit Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 28/32] package/systemd: add optional support for hwdb Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 29/32] package/systemd: add optional support for hibernation Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 30/32] package/systemd: use 'menuconfig' Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 31/32] package/systemd: only create 'systemd-journal' group Gabe Evans
2016-02-25 21:55 ` [Buildroot] [PATCH 32/32] package/systemd: remove unnecessary make opts Gabe Evans
2016-06-07 20:21 ` [Buildroot] [PATCH 00/32] systemd feature selection Yann E. MORIN
2016-07-01  8:37   ` Maxime Hadjinlian
2016-07-01 23:00     ` Gabe Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF91EA.6040300@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox