Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sox: disable SSP when using MIPS Codescape toolchains
Date: Tue, 1 Mar 2016 10:36:08 +0000	[thread overview]
Message-ID: <56D57098.3020307@imgtec.com> (raw)
In-Reply-To: <87bn6ymqsv.fsf@dell.be.48ers.dk>

Hi Peter,

On 01/03/16 10:32, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> 
>  > MIPS Codescape toolchains don't support stack-smashing protection
>  > despite of using glibc, therefore we see failures like this one:
> 
>  > mips-img-linux-gnu/bin/ld: cannot find -lssp
> 
>  > Fixes:
>  >   http://autobuild.buildroot.net/results/957/95721f7b88c46a20202fb02e408817097df965c3/
> 
>  > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>  > ---
>  >  package/sox/sox.mk | 6 ++++++
>  >  1 file changed, 6 insertions(+)
> 
>  > diff --git a/package/sox/sox.mk b/package/sox/sox.mk
>  > index f4d1608..61f5220 100644
>  > --- a/package/sox/sox.mk
>  > +++ b/package/sox/sox.mk
>  > @@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
>  >  SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
>  >  SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
>  
>  > +# MIPS Codescape toolchains don't support stack-smashing protection
>  > +# despite of using glibc.
>  > +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
>  > +SOX_CONF_OPTS += --disable-stack-protector
>  > +endif
> 
> Committed, thanks (for 2016.02). Please consider generalizing it like
> Thomas suggested for the 2016.05 cycle.
> 

Sure, I will do it.

Thanks,

Vincent.

      reply	other threads:[~2016-03-01 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 16:39 [Buildroot] [PATCH] sox: disable SSP when using MIPS Codescape toolchains Vicente Olivert Riera
2016-02-29 16:51 ` Thomas Petazzoni
2016-02-29 17:00   ` Vicente Olivert Riera
2016-02-29 20:08     ` Thomas Petazzoni
2016-03-01 10:40       ` Peter Korsgaard
2016-03-01 10:32 ` Peter Korsgaard
2016-03-01 10:36   ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D57098.3020307@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox