From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Ceresoli <luca@lucaceresoli.net>
Date: Wed, 9 Mar 2016 00:01:34 +0100
Subject: [Buildroot] [PATCH 2/2] libpjsip: fix optional dependency on
 libsrtp
In-Reply-To: <20160308211526.6a639ffb@free-electrons.com>
References: <1457387805-4084-1-git-send-email-luca@lucaceresoli.net>
 <1457387805-4084-2-git-send-email-luca@lucaceresoli.net>
 <20160308211526.6a639ffb@free-electrons.com>
Message-ID: <56DF59CE.7000505@lucaceresoli.net>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 08/03/2016 21:15, Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
> 
> On Mon,  7 Mar 2016 22:56:45 +0100, Luca Ceresoli wrote:
> 
>> +ifeq ($(BR2_PACKAGE_LIBSRTP),y)
>> +LIBPJSIP_DEPENDENCIES += libsrtp
>> +LIBPJSIP_CONF_OPTS += --with-external-srtp=$(STAGING_DIR)/usr
>> +endif
> 
> The --with-external-srtp seems to imply that there is also an
> "internal/bundled" srtp.
> 
> If pjsip indeed needs srtp unconditionally, then we should always
> depend on it and use the external libsrtp rather than the bundled one.

Uh, indeed libpjsip always links libsrtp, and ships the internal copy in
case the no external one is found.

Updated patch incoming.

-- 
Luca