Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Best regards
Date: Wed, 9 Mar 2016 13:43:05 +0100	[thread overview]
Message-ID: <56E01A59.5090606@gmail.com> (raw)
In-Reply-To: <1457276783-27985-1-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

Le 06/03/2016 16:06, Thomas Petazzoni a ?crit :
> Now that we have added support for the lastest binutils version 2.26,
> it is time to remove the oldest version we currently support, 2.23, in
> order to keep only 3 versions: 2.24, 2.25 and 2.26.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---

[snip]

> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index a532283..b5b0154 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -7,15 +7,6 @@ choice
>  	help
>  	  Select the version of binutils you wish to use.
>  
> -	config BR2_BINUTILS_VERSION_2_23_X
> -		depends on !BR2_aarch64 && !BR2_microblaze && \
> -			   !BR2_powerpc64le && !BR2_nios2
> -		# Unsupported for MIPS R6
> -		depends on !BR2_mips_32r6 && !BR2_mips_64r6
> -		# Unsupported ARM cores
> -		depends on !BR2_cortex_a17
> -		bool "binutils 2.23.2"
> -
>  	config BR2_BINUTILS_VERSION_2_24_X
>  		# supported, but broken on Nios-II and powerpc64le
>  		depends on !BR2_nios2 && !BR2_powerpc64le
> @@ -36,7 +27,6 @@ endchoice
>  config BR2_BINUTILS_VERSION
>  	string
>  	default "arc-2015.12"	if BR2_arc
> -	default "2.23.2"	if BR2_BINUTILS_VERSION_2_23_X
>  	default "2.24"		if BR2_BINUTILS_VERSION_2_24_X
>  	default "2.25.1"	if BR2_BINUTILS_VERSION_2_25_X
>  	default "2.26"		if BR2_BINUTILS_VERSION_2_26_X
> 

Since BR2_BINUTILS_VERSION_2_23_X symbol is removed we need to add it to
Config.in.legacy. Otherwise the old symbol BR2_BINUTILS_VERSION_2_23_2 which
select BR2_BINUTILS_VERSION_2_23_X do nothing.

Maybe we can also remove the binutils 2.22 and 2.23 hashes ?

Best regards,
Romain

  parent reply	other threads:[~2016-03-09 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 15:06 [Buildroot] [PATCH 1/2] binutils: remove support for version 2.23 Thomas Petazzoni
2016-03-06 15:06 ` [Buildroot] [PATCH 2/2] binutils: switch to version 2.25 by default Thomas Petazzoni
2016-03-09 12:59   ` Romain Naour
2016-03-10 22:08   ` Peter Korsgaard
2016-03-09 12:43 ` Romain Naour [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-02  1:58 [Buildroot] [PATCH v3 1/2] sdl_mixer: add patch to fix SDL_mixer.pc for static linking Rodrigo Rebello
2016-03-02  1:58 ` [Buildroot] [PATCH v3 2/2] chocolate-doom: add patch to fix " Rodrigo Rebello
2016-03-05 15:56   ` [Buildroot] Best regards Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E01A59.5090606@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox