Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libglib2: improve dev file removal
Date: Wed, 9 Mar 2016 21:22:07 -0300	[thread overview]
Message-ID: <56E0BE2F.9020202@zacarias.com.ar> (raw)
In-Reply-To: <20160309174749.46cf1ea0@free-electrons.com>

On 09/03/16 13:47, Thomas Petazzoni wrote:

> Seems better, at least I understand. There is one minor point I don't
> entirely like is that you make an assumption on the ordering of the
> install target hooks calls.
>
> Therefore, I think I would have preferred:
>
> ifneq ($(BR2_PACKAGE_GDB),y)
> define LIBGLIB2_REMOVE_GDB_FILES
>          rm -rf $(TARGET_DIR)/usr/share/glib-2.0/gdb
> endef
> endif
>
> define LIBGLIB2_REMOVE_DEV_FILES
> 	rm -rf $(TARGET_DIR)/usr/lib/glib-2.0
> 	rm -rf $(addprefix $(TARGET_DIR)/usr/share/glib-2.0/,codegen gettext schemas)
> 	$(LIBGLIB2_REMOVE_GDB_FILES)
> 	rmdir --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share/glib-2.0
> 	...
> endef
>
> But it's really a minor point, and somewhat pedantic, I admit, so I'm
> also fine with your patch as-is.
>
> Best regards,
>
> Thomas

Hi.
This requires some refinement which i stumbled upon when testing 
gsettings, the schema sources itself (xml files) aren't required, 
however some programs (not yet submitted) require the compiled result, 
which is normally /usr/share/glib-2.0/schemas/gschemas.compiled
But, we don't handle that at all, so it won't work either way.
I'll add the post-processing hook for this to work properly and resend 
both the cleanup plus the compile, which will likely be via host 
glib-compile-schemas from staging schemas (which will require some 
packages to enable staging install).
Regards.

      reply	other threads:[~2016-03-10  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 16:39 [Buildroot] [PATCH v2] libglib2: improve dev file removal Gustavo Zacarias
2016-03-09 16:47 ` Thomas Petazzoni
2016-03-10  0:22   ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E0BE2F.9020202@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox