From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Fri, 18 Mar 2016 22:33:40 +0100 Subject: [Buildroot] [PATCH 08/16] toolchain-buildroot: update glibc comment for noMMU In-Reply-To: <20160318214946.61d39157@free-electrons.com> References: <1458164602-16983-1-git-send-email-thomas.petazzoni@free-electrons.com> <1458164602-16983-9-git-send-email-thomas.petazzoni@free-electrons.com> <56E9E9BD.2040107@mind.be> <20160318214946.61d39157@free-electrons.com> Message-ID: <56EC7434.6030209@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 03/18/16 21:49, Thomas Petazzoni wrote: > Hello, > > On Thu, 17 Mar 2016 00:18:21 +0100, Arnout Vandecappelle wrote: > >>> comment "(e)glibc only available with shared lib support" >>> + depends on BR2_USE_MMU >> >> Actually, the rest of the architecture dependencies should also be repeated >> then. It's a huge blob, so maybe introduce GLIBC_ARCH_DEPENDS? Which could, by >> the way, also be used to protect comments for packages that depend on glibc. > > I'll be happy to do that, however if you agree, I'd prefer to handle it > in a separate patch series. This one is already 18 patches long (in its > new version), and the problem you're pointing is not introduced by my > patch series. Well, I don't think it makes sense to add the noMMU dependency without the rest of the arch dependencies. So just drop this patch from the series I'd say. Regards, Arnout > > Once this patch series is merged, I'll take care of introducing > foo_ARCH_DEPENDS options for the different C libraries. > > Is it OK for you? > > Thomas > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF