Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ltp-testsuite: build kernel modules when appropriate
Date: Tue, 29 Mar 2016 21:12:11 +0200	[thread overview]
Message-ID: <56FAD38B.8040201@mind.be> (raw)
In-Reply-To: <56F92840.9090206@free.fr>

On 03/28/16 14:49, Mason wrote:
> On 24/03/2016 22:25, Thomas Petazzoni wrote:
>
>> On Thu, 24 Mar 2016 15:02:59 +0100, Mason wrote:
>>
>>> +ifeq ($(BR2_LINUX_KERNEL),y)
>>> +LTP_TESTSUITE_DEPENDENCIES += linux
>>> +LTP_TESTSUITE_CONF_OPTS += --with-linux-dir=$(LINUX_DIR)
>>> +else
>>> +LTP_TESTSUITE_CONF_OPTS += --without-modules
>>> +endif
>>
>> It looks good in principle, but unfortunately in practice it doesn't
>> work. Try to build the following configuration: [snip]
>>
>> And you will see that the LTP kernel modules are not built. And the
>> reason is that it tries to build them without passing the appropriate
>> ARCH= variable, so it falls back to x86, and therefore fails to build
>> them. Here is what I see: [snip]
>>
>> And then lots and lots of errors about arch/x86 related headers. And
>> indeed, my kernel is configured/built for ARM.
>>
>> So maybe it worked if you tested for a x86 target, but I'm a bit
>> confused since I know you're working on ARM stuff. Maybe you have
>> ARCH=arm defined globally in your environment and therefore it makes
>> things work?
>
> Yes, you hit the nail on the head. Since I work exclusively with
> ARM platforms, I have ARCH=arm exported in my environment.
>
>> Could you look into this and send an updated patch?
>
> I'm not sure what the correct solution is. We discussed the issue
> a few days ago, and you mentioned KERNEL_ARCH.
>
> Should I just export ARCH=$(KERNEL_ARCH) in the environment?
>
> But I'm not sure how to do it globally, or whether that is the
> appropriate solution... Could someone provide some guidance?

  You need to add that to LTP_TESTSUITE_MAKE_ENV:

LTP_TESTSUITE_MAKE_ENV = ARCH=$(KERNEL_ARCH)

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-03-29 19:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 14:02 [Buildroot] [PATCH] ltp-testsuite: build kernel modules when appropriate Mason
2016-03-24 21:25 ` Thomas Petazzoni
2016-03-28 12:49   ` Mason
2016-03-29 19:12     ` Arnout Vandecappelle [this message]
2016-04-04 13:08       ` [Buildroot] [PATCH v2] " Mason
2016-04-05  9:23         ` Arnout Vandecappelle
2016-04-05 11:09           ` [Buildroot] [PATCH v3] " Mason
2016-04-14 19:29             ` Mason
2016-04-18 19:42             ` Thomas Petazzoni
2016-04-18 20:03               ` Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FAD38B.8040201@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox