[Buildroot] [PATCH v2 06/17] uclibc: gcc >= 4.9 can build a thumb/thread uclibc

[Arnout Vandecappelle <arnout@mind.be>]

On 03/30/16 00:18, Thomas Petazzoni wrote:
> Hello,
>
> On Sat, 19 Mar 2016 16:53:16 +0100, Arnout Vandecappelle wrote:
>
>>> -# Thumb build is broken with threads, build in ARM mode
>>> -ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB)$(BR2_TOOLCHAIN_HAS_THREADS),yy)
>>> +# Thumb1 build is broken with threads with old gcc versions (4.7 and
>>> +# 4.8). Since all cores supporting Thumb1 also support ARM, we use ARM
>>> +# code in this case.
>>> +ifeq ($(BR2_GCC_VERSION_4_7_X)$(BR2_GCC_VERSION_4_8_X):$(BR2_ARM_INSTRUCTIONS_THUMB)$(BR2_TOOLCHAIN_HAS_THREADS),y:yy)
>>
>>    This line is a bit long so would be nicer to split off into separate
>> variables. This kind of logic is also much easier to do (and certainly easier to
>> understand) in Kconfig than in the make language - like we had for BX before you
>> removed it.
>
> I agree this line is a bit long. But how would be named this Config.in
> option? BR2_PACKAGE_UCLIBC_FORCE_ARM ?

  Maybe FORCE_NO_THUMB?

>
> config BR2_PACKAGE_UCLIBC_FORCE_ARM
> 	bool
> 	depends on BR2_ARM_INSTRUCTIONS_THUMB
> 	depends on BR2_TOOLCHAIN_HAS_THREADS
> 	default y if BR2_GCC_VERSION_4_7_X
> 	default y if BR2_GCC_VERSION_4_8_X
>
> Something like that?

  Yep, that's it.


  Regards,
  Arnout

>
> Thomas
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF