From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 5/7] barebox: extract package name argument
Date: Tue, 5 Apr 2016 01:01:32 +0200 [thread overview]
Message-ID: <5702F24C.7020209@mind.be> (raw)
In-Reply-To: <1458513351-6556-6-git-send-email-pieter@boesman.nl>
On 03/20/16 23:35, Pieter Smith wrote:
> No functional changes: Extracts an argument to the inner-barebox-package
> function to automatically determine the uppercase package name. This is needed
> to support a 2nd config build. This results in the following renaming:
> 'BAREBOX' -> '$(1)'
>
> All barebox packages are meant to be built from the same sources, so related
> KConfig variables (origin, version and patch directory) are not extracted.
The first paragraph of the commit message makes it sound as if all BAREBOX
instances are replaced with $(1), which is not true (as clarified by the second
paragraph). But I don't see how to formulate it better, so:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Signed-off-by: Pieter Smith <pieter@boesman.nl>
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-04-04 23:01 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 22:35 [Buildroot] [PATCH v4 0/7] Support building a second Barebox config (incl. BBB) Pieter Smith
2016-03-20 22:35 ` [Buildroot] [PATCH v4 1/7] barebox: support multi-image-build image selection Pieter Smith
2016-03-31 5:44 ` Yegor Yefremov
2016-04-06 20:28 ` Pieter Smith
2016-04-02 15:31 ` Thomas Petazzoni
2016-04-04 22:08 ` Arnout Vandecappelle
2016-04-04 22:16 ` Arnout Vandecappelle
2016-03-20 22:35 ` [Buildroot] [PATCH v4 2/7] barebox: friendly error on missing built image Pieter Smith
2016-03-31 6:01 ` Yegor Yefremov
2016-03-20 22:35 ` [Buildroot] [PATCH v4 3/7] barebox: support custom barebox output image name Pieter Smith
2016-03-31 6:03 ` Yegor Yefremov
2016-04-04 22:31 ` Arnout Vandecappelle
2016-04-04 23:20 ` Arnout Vandecappelle
2016-04-06 14:53 ` Thomas Petazzoni
2016-04-06 20:14 ` Pieter Smith
2016-04-06 23:06 ` Arnout Vandecappelle
2016-04-08 7:51 ` Pieter Smith
2016-03-20 22:35 ` [Buildroot] [PATCH v4 4/7] barebox: introduce barebox-package function Pieter Smith
2016-03-31 6:12 ` Yegor Yefremov
2016-04-04 22:59 ` Arnout Vandecappelle
2016-04-04 23:23 ` Arnout Vandecappelle
2016-04-06 20:26 ` Pieter Smith
2016-03-20 22:35 ` [Buildroot] [PATCH v4 5/7] barebox: extract package name argument Pieter Smith
2016-03-31 6:16 ` Yegor Yefremov
2016-04-04 23:01 ` Arnout Vandecappelle [this message]
2016-03-20 22:35 ` [Buildroot] [PATCH v4 6/7] barebox: support 2nd config build Pieter Smith
2016-03-31 6:17 ` Yegor Yefremov
2016-04-04 23:25 ` Arnout Vandecappelle
2016-04-24 7:53 ` Pieter Smith
2016-03-20 22:35 ` [Buildroot] [PATCH v4 7/7] beaglebone: adds barebox bootloader defconfig Pieter Smith
2016-03-31 6:21 ` Yegor Yefremov
2016-04-04 23:37 ` Arnout Vandecappelle
2016-04-19 20:26 ` Pieter Smith
2016-04-19 22:13 ` Arnout Vandecappelle
2016-04-23 11:39 ` Pieter Smith
2016-03-21 11:38 ` [Buildroot] [PATCH v4 0/7] Support building a second Barebox config (incl. BBB) Yegor Yefremov
2016-03-21 11:56 ` Pieter Smith
2016-04-19 19:24 ` Thomas Petazzoni
2016-04-19 20:17 ` Pieter Smith
2016-04-20 14:42 ` Yegor Yefremov
2016-04-20 16:42 ` Pieter Smith
2016-04-21 10:55 ` Yegor Yefremov
2016-04-21 11:29 ` Thomas Petazzoni
2016-04-23 13:01 ` Pieter Smith
2016-04-23 13:11 ` Thomas Petazzoni
2016-04-23 14:35 ` Pieter Smith
2016-04-23 14:50 ` Thomas Petazzoni
2016-04-23 16:18 ` Pieter Smith
2016-04-23 19:26 ` Thomas Petazzoni
2016-04-24 8:04 ` Pieter Smith
2016-04-24 8:16 ` Thomas Petazzoni
2016-04-24 8:32 ` Pieter Smith
2016-04-24 8:47 ` Thomas Petazzoni
2016-04-24 8:50 ` Pieter Smith
2016-04-24 8:47 ` Pieter Smith
2016-04-24 19:18 ` Peter Korsgaard
2016-04-24 21:26 ` Pieter Smith
2016-04-23 13:05 ` Pieter Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702F24C.7020209@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox