From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] opencv: fix sparc64 compile
Date: Tue, 5 Apr 2016 09:37:55 +0200 [thread overview]
Message-ID: <57036B53.6080509@mind.be> (raw)
In-Reply-To: <20160404194344.GB5944@waldemar-brodkorb.de>
On 04/04/16 21:43, Waldemar Brodkorb wrote:
> Hi Arnout,
> Arnout Vandecappelle wrote,
>
>> On 04/03/16 13:09, Waldemar Brodkorb wrote:
>>> This patch from Debian fixes following autobuild failure:
>>> http://autobuild.buildroot.net/results/eda5c6c43da40a342e0f545a348d2f865eb5ccf2/
>>>
>>> Tested with ARM build without a regression.
>>>
>>> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
>>> ---
>>> package/opencv/0002-atomic.patch | 222 +++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 222 insertions(+)
>>> create mode 100644 package/opencv/0002-atomic.patch
>>>
>>> diff --git a/package/opencv/0002-atomic.patch b/package/opencv/0002-atomic.patch
>>> new file mode 100644
>>> index 0000000..607d3fd
>>> --- /dev/null
>>> +++ b/package/opencv/0002-atomic.patch
>>> @@ -0,0 +1,222 @@
>>> +Bug#714923: opencv FTBFS on sparc64
>>> +https://www.mail-archive.com/debian-bugs-dist at lists.debian.org/msg1393793.html
>>> +
>>
>> You should sign off the patch. It is also missing a description of what is
>> wrong and how it is fixed.
>
> Thanks for the review.
> I thought Signed-off-By is only used if I made the patch and not if
> I copy the patch from some internet site.
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
Third paragraph.
Regards,
Arnout
>
>> Also please refer to the bug tracker itself rather than the mail archive:
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714923
>>
>> The first message there contains a nice description of the problem that you
>> can reuse in the patch.
>
> Okay,
>
> Waldemar
>
--
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
prev parent reply other threads:[~2016-04-05 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 11:09 [Buildroot] [PATCH] opencv: fix sparc64 compile Waldemar Brodkorb
2016-04-04 19:40 ` Arnout Vandecappelle
2016-04-04 19:43 ` Waldemar Brodkorb
2016-04-05 7:37 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57036B53.6080509@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox