[Buildroot] [RFC PATCH] configs: atmel: add sd card demo for sama5d2 xplained

[Arnout Vandecappelle <arnout@mind.be>]

On 04/06/16 17:53, Ludovic Desroches wrote:
> This demo defconfig adds packages to have an equivalent root filesystem
> to the one generated by Yocto with atmel-xplained-demo-image.
> ---
>
> Hi,
>
> Since we will remove the at91 fork of the Buildroot repository. We would like
> to provide a turnkey solution as we do with Yocto. At the moment, it is only
> a basic set of packages.
>
> My concern is we would like to provide a SD card demo but also a NAND demo. It
> means about 6 demo defconfigs to add. Is it an issue?

  No, I don't think it's an issue.

  It may be a good occasion to improve support for split defconfigs. Once we see 
a bit the commonalities.

>
> Regards
>
> Ludovic
>
>   configs/atmel_sama5d2_xplained_mmc_demo_defconfig | 85 +++++++++++++++++++++++
>   1 file changed, 85 insertions(+)
>   create mode 100644 configs/atmel_sama5d2_xplained_mmc_demo_defconfig
>
> diff --git a/configs/atmel_sama5d2_xplained_mmc_demo_defconfig b/configs/atmel_sama5d2_xplained_mmc_demo_defconfig

  I think "demo" is not a great name, if we want more different demos later. 
Maybe "dev" because it's mostly development tools that are added?

> new file mode 100644
> index 0000000..792b8cc
> --- /dev/null
> +++ b/configs/atmel_sama5d2_xplained_mmc_demo_defconfig
> @@ -0,0 +1,85 @@
> +BR2_arm=y
> +BR2_cortex_a5=y
> +BR2_ARM_ENABLE_NEON=y
> +BR2_ARM_ENABLE_VFP=y
> +BR2_ARM_FPU_VFPV4=y
> +BR2_ARM_INSTRUCTIONS_THUMB2=y

  Can you add some comments in the defconfig file like we do for most other 
defconfigs?

> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y

  Like here, explain why wchar is needed.

> +BR2_PTHREAD_DEBUG=y

  And definitely this one needs explanation.

> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/atmel/sama5d2_xplained_mmc/post-image.sh"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux4sam_5.2"

  It's github, you can use an URL rather than a git clone.

> +BR2_LINUX_KERNEL_DEFCONFIG="sama5"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d2_xplained at91-sama5d2_xplained_pda4 at91-sama5d2_xplained_pda7 at91-sama5d2_xplained_pda7b"

  For the packages it would also be nice to order them into logical sections, 
with comments.

> +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> +BR2_PACKAGE_ALSA_UTILS=y
> +BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
> +BR2_PACKAGE_ALSA_UTILS_APLAY=y
> +BR2_PACKAGE_FFMPEG=y
> +BR2_PACKAGE_FFMPEG_GPL=y
> +BR2_PACKAGE_FFMPEG_SWSCALE=y
> +BR2_PACKAGE_MPG123=y
> +BR2_PACKAGE_BZIP2=y
> +BR2_PACKAGE_GZIP=y
> +BR2_PACKAGE_UNZIP=y
> +BR2_PACKAGE_XZ=y
> +BR2_PACKAGE_ZIP=y
> +BR2_PACKAGE_GDB=y
> +BR2_PACKAGE_LMBENCH=y
> +BR2_PACKAGE_DOSFSTOOLS=y
> +BR2_PACKAGE_DOSFSTOOLS_FATLABEL=y
> +BR2_PACKAGE_DOSFSTOOLS_FSCK_FAT=y
> +BR2_PACKAGE_DOSFSTOOLS_MKFS_FAT=y
> +BR2_PACKAGE_MMC_UTILS=y
> +BR2_PACKAGE_MTD=y
> +BR2_PACKAGE_WILC1000_FIRMWARE=y

  Is the wifi always populated? If yes, I think it would make sense to include 
the wifi userspace in the basic defconfig. IMHO the basic defconfig should 
include everything to get the hardware running. In fact, I think that also the 
GPU libs should be included in the basic defconfig.


  Regards,
  Arnout


> +BR2_PACKAGE_DEVMEM2=y
> +BR2_PACKAGE_EVTEST=y
> +BR2_PACKAGE_I2C_TOOLS=y
> +BR2_PACKAGE_SETSERIAL=y
> +BR2_PACKAGE_SPI_TOOLS=y
> +BR2_PACKAGE_USBUTILS=y
> +BR2_PACKAGE_LIBDRM=y
> +BR2_PACKAGE_LIBDRM_INSTALL_TESTS=y
> +BR2_PACKAGE_DTC=y
> +BR2_PACKAGE_DTC_PROGRAMS=y
> +BR2_PACKAGE_BLUEZ_UTILS=y
> +BR2_PACKAGE_BRIDGE_UTILS=y
> +BR2_PACKAGE_CAN_UTILS=y
> +BR2_PACKAGE_DROPBEAR=y
> +BR2_PACKAGE_ETHTOOL=y
> +BR2_PACKAGE_IPERF=y
> +BR2_PACKAGE_IPROUTE2=y
> +BR2_PACKAGE_IPTABLES=y
> +BR2_PACKAGE_IW=y
> +BR2_PACKAGE_LRZSZ=y
> +BR2_PACKAGE_MII_DIAG=y
> +BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_WGET=y
> +BR2_PACKAGE_WIRELESS_TOOLS=y
> +BR2_PACKAGE_WPA_SUPPLICANT=y
> +BR2_PACKAGE_BASH=y
> +BR2_PACKAGE_HTOP=y
> +BR2_PACKAGE_VIM=y
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_AT91BOOTSTRAP3=y
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.4"
> +BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d2_xplainedsd_uboot"
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/linux4sam/u-boot-at91.git"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="linux4sam_5.2"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d2_xplained_mmc"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF