From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wojciech Nizinski <niziak@spox.org>
Date: Thu, 7 Apr 2016 09:35:56 +0200
Subject: [Buildroot] [PATCH 1/1] new package: alsacap
In-Reply-To: <570590D7.30005@mind.be>
References: <1459926063-11265-1-git-send-email-niziak@spox.org>
 <570590D7.30005@mind.be>
Message-ID: <57060DDC.1000702@spox.org>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Is any tool available to check format of BR files (something like vera++) ?

On 07.04.2016 00:42, Arnout Vandecappelle wrote:
>  In addition to Yegor's comments...
>
> On 04/06/16 09:01, Wojciech Nizinski wrote:
>> Alsa capability tool displays the capabilities of your sound card and
>> its ALSA driver
>>
>> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
>> ---
>>   package/Config.in          |  1 +
>>   package/alsacap/Config.in  |  5 +++++
>>   package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
>>   3 files changed, 28 insertions(+)
>>   create mode 100644 package/alsacap/Config.in
>>   create mode 100644 package/alsacap/alsacap.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index bdc3063..dd6c1d9 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -5,6 +5,7 @@ menu "Target packages"
>>
>>   menu "Audio and video applications"
>>       source "package/alsa-utils/Config.in"
>> +    source "package/alsacap/Config.in"
>>       source "package/aumix/Config.in"
>>       source "package/bellagio/Config.in"
>>       source "package/dvblast/Config.in"
>> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
>> new file mode 100644
>> index 0000000..d472973
>> --- /dev/null
>> +++ b/package/alsacap/Config.in
>> @@ -0,0 +1,5 @@
>> +config BR2_PACKAGE_ALSACAP
>> +    bool "alsacap"
>> +    depends on BR2_PACKAGE_ALSA_LIB
>
>  Use select instead of depends:
>
>     depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
>     select BR2_PACKAGE_ALSA_LIB
>
>  Because there is a dependency on threads, you also need to add a 
> comment to clarify that (cfr. the manual).
>
>> +    help
>> +        Alsa capability tool displays the capabilities of your sound 
>> card and its ALSA driver.
>
>  Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where 
> tab counts for 8, so 62 characters).
>
>> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
>> new file mode 100644
>> index 0000000..391947c
>> --- /dev/null
>> +++ b/package/alsacap/alsacap.mk
>> @@ -0,0 +1,22 @@
>> +################################################################################ 
>>
>> +#
>> +# alsacap
>> +#
>> +################################################################################ 
>>
>> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
>> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
>> +
>
>  Remove this empty line.
>
>> +ALSACAP_LICENSE = ISC licence
>> +ALSACAP_LICENSE_FILES = COPYING
>> +
>
>  Here as well.
>
>
>  Regards,
>  Arnout
>
>> +ALSACAP_DEPENDENCIES = alsa-lib
>> +
>> +define ALSACAP_BOOTSTRAP
>> +    cd $(@D) && ./bootstrap
>> +endef
>> +
>> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
>> +
>> +$(eval $(autotools-package))
>> +
>> +
>>
>
>