Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] host-gcc: apply patches stored in global patches directories
Date: Tue, 12 Apr 2016 22:05:43 +0200	[thread overview]
Message-ID: <570D5517.9000304@mind.be> (raw)
In-Reply-To: <1460343675-19551-1-git-send-email-hchunhui@mail.ustc.edu.cn>

On 04/11/16 05:01, He Chunhui wrote:
> When building host gcc, patches stored in global patches directories are skipped.
> This patch fixes the unexpected behavior.

  That's because they should be in subdirectories gcc-initial and gcc-final. But 
I agree that it's unexpected behaviour...

>
> Signed-off-by: He Chunhui <hchunhui@mail.ustc.edu.cn>
> ---
>   package/gcc/gcc.mk | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
> index 5646b66..de9a65c 100644
> --- a/package/gcc/gcc.mk
> +++ b/package/gcc/gcc.mk
> @@ -42,9 +42,15 @@ endif
>   endif
>
>   define HOST_GCC_APPLY_PATCHES
> -	if test -d package/gcc/$(GCC_VERSION); then \
> -	  $(APPLY_PATCHES) $(@D) package/gcc/$(GCC_VERSION) \*.patch ; \
> -	fi;
> +	for D in \
> +	    package/gcc/$(GCC_VERSION) \
> +	    $(addsuffix /gcc,$(call qstrip,$(BR2_GLOBAL_PATCH_DIR)))/$(GCC_VERSION) \
> +	    $(addsuffix /gcc,$(call qstrip,$(BR2_GLOBAL_PATCH_DIR))) \

  You ahould also add this to HOST_GCC_COMMON_CCACHE_HASH_FILES, below, to make 
sure that the ccache hash is updated appropriately. Make sure you update the 
comment there as well.

> +	    ; do \
> +	  if test -d $${D}; then \

  This should be indented with two tabs.

> +	    $(APPLY_PATCHES) $(@D) $${D} \*.patch || exit 1; \

  And three tabs here.


  Regards,
  Arnout

> +	  fi; \
> +	done;
>   	$(HOST_GCC_APPLY_POWERPC_PATCH)
>   endef
>
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

      reply	other threads:[~2016-04-12 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11  3:01 [Buildroot] [PATCH] host-gcc: apply patches stored in global patches directories He Chunhui
2016-04-12 20:05 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570D5517.9000304@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox