Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures
Date: Thu, 21 Apr 2016 22:57:21 +0200	[thread overview]
Message-ID: <57193EB1.5060509@mind.be> (raw)
In-Reply-To: <1461268365-13922-1-git-send-email-thomas.petazzoni@free-electrons.com>

On 04/21/16 21:52, Thomas Petazzoni wrote:
> We were not defining BR2_ARCH for two of the x86 subarchitecture,
> which means the architecture part of the GNU_TARGET_NAME tuple was
> empty, leading to weird build failures.
>
> This commit fixes that by defining the appropriate values.
>
> Fixes bug #8861.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  It would be nice if we would have a way to check something like that...

  Regards,
  Arnout

> ---
>   arch/Config.in.x86 | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index 4039db8..efa9567 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -226,6 +226,8 @@ config BR2_ARCH
>   	default "i686"		if BR2_x86_nocona && BR2_i386
>   	default "i686"		if BR2_x86_core2 && BR2_i386
>   	default "i686"		if BR2_x86_corei7 && BR2_i386
> +	default "i686"		if BR2_x86_corei7_avx && BR2_i386
> +	default "i686"		if BR2_x86_corei7_avx2 && BR2_i386
>   	default "i686"		if BR2_x86_atom && BR2_i386
>   	default "i686"		if BR2_x86_opteron && BR2_i386
>   	default "i686"		if BR2_x86_opteron_sse3 && BR2_i386
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-04-21 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21 19:52 [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures Thomas Petazzoni
2016-04-21 20:57 ` Arnout Vandecappelle [this message]
2016-04-21 21:02   ` Thomas Petazzoni
2016-04-21 23:05     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57193EB1.5060509@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox