Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org
Date: Wed, 27 Apr 2016 16:38:38 -0300	[thread overview]
Message-ID: <5721153E.6040608@free-electrons.com> (raw)
In-Reply-To: <20160427213230.0ee9fe71@free-electrons.com>

On 27/04/16 16:32, Thomas Petazzoni wrote:

> I know that may sound like a nitpicking debate, but I'm wondering if we
> shouldn't keep BR2_PACKAGE_MESA3D_OPENGL_GL as an internal mesa3d
> symbol, and instead use:
>
> 	depends on BR2_PACKAGE_HAS_LIBGL && BR2_PACKAGE_MESA3D
>
> which really expresses what we want: we want an OpenGL implementation,
> and this OpenGL implementation has to be mesa3d.
>
> Thomas

I'm fine with nitpicking, however we already use
BR2_PACKAGE_MESA3D_OPENGL_EGL and BR2_PACKAGE_MESA3D_OPENGL_ES in 
glmark2 and weston, which could also ostensibly be replaced by the more 
verbose conditional.
Granted, for weston what it really wants is wayland-egl, which AFAIK 
with our current packages is only provided by mesa3d.
Also while nitpicking the xorg drivers only want DRI so we can keep that 
as is since the xorg conditional is in there already (packages in x11r7/ 
already depend on xorg, plus mesa3d_dri gives opengl). Kind of a maybe 
take back my ACKs for the drivers.
Regards.

  reply	other threads:[~2016-04-27 19:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 12:20 [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org Bernd Kuhls
2016-04-27 19:05   ` Gustavo Zacarias
2016-04-27 19:32   ` Thomas Petazzoni
2016-04-27 19:38     ` Gustavo Zacarias [this message]
2016-04-27 19:49       ` Thomas Petazzoni
2016-04-27 19:54         ` Gustavo Zacarias
2016-04-27 20:52         ` Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 3/8] package/kodi: Update OpenGL check Bernd Kuhls
2016-04-27 19:05   ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 4/8] package/libva: " Bernd Kuhls
2016-04-27 19:06   ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 5/8] package/x11r7/xdriver_xf86-video-intel: " Bernd Kuhls
2016-04-27 19:06   ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 6/8] package/x11r7/xdriver_xf86-video-mach64: " Bernd Kuhls
2016-04-27 19:07   ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 7/8] package/x11r7/xdriver_xf86-video-r128: " Bernd Kuhls
2016-04-27 19:11   ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 8/8] package/x11r7/xserver_xorg-server: " Bernd Kuhls
2016-04-27 19:11   ` Gustavo Zacarias
2016-04-27 19:04 ` [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Gustavo Zacarias
2016-04-27 19:30 ` Thomas Petazzoni
2016-04-27 20:46   ` Bernd Kuhls
2016-04-27 20:56     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5721153E.6040608@free-electrons.com \
    --to=gustavo.zacarias@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox