From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] imagemagick: bump to version 7.0.2-0
Date: Mon, 20 Jun 2016 10:35:29 -0300 [thread overview]
Message-ID: <5767F121.5010603@zacarias.com.ar> (raw)
In-Reply-To: <20160619104526.71cbfe65@free-electrons.com>
On 19/06/16 05:45, Thomas Petazzoni wrote:
> So can we have your Acked-by and/or Reviewed-by on this oldest patch?
Hi.
I'd ack it as is, however it needs a rebase, probably better to send a
respin?
Rationale is simple: users might not necessarily install fonts via the
ghostscript-fonts package (addressing Baruch's conditional concerns),
but then my concern is how much of the functionality is really true
without ghostscript itself (there are checks in configure):
-------------------------------------------------------------
checking for Ghostscript...
checking for Ghostscript version... 9.15
checking for gs color device... pnmraw
checking for gs alpha device... pngalpha
checking for gs CMYK device... pamcmyk32
checking for gs mono device... pbmraw
checking for gs PDF writing device... pdfwrite
checking for gs PS writing device... ps2write
checking for gs EPS writing device... eps2write
-------------------------------------------------------------
Which also leaks from the host/distro as we can see, and can't be easily
turned off (lots of AC_CHECK_PROG plus other manual checks).
Which begs the question... how useful are the fonts without these? (i
don't know the answer, i never used imagemagick that way).
But then the simple 'convert -list font' goes from empty to working with
ghostscript-fonts installed, hence in the end it looks correct from a
data file point of view, so i side with it being fine.
Regards.
prev parent reply other threads:[~2016-06-20 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 12:34 [Buildroot] [PATCH 1/3] imagemagick: bump to version 7.0.2-0 Gustavo Zacarias
2016-06-15 12:34 ` [Buildroot] [PATCH 2/3] imagemagick: add explicit pango support Gustavo Zacarias
2016-06-15 12:34 ` [Buildroot] [PATCH 3/3] imagemagick: add explicit lzma (xz) support Gustavo Zacarias
2016-06-15 21:12 ` [Buildroot] [PATCH 1/3] imagemagick: bump to version 7.0.2-0 Thomas Petazzoni
2016-06-16 20:22 ` Yann E. MORIN
2016-06-19 3:31 ` Gustavo Zacarias
2016-06-19 8:45 ` Thomas Petazzoni
2016-06-20 13:35 ` Gustavo Zacarias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767F121.5010603@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox