From: Andreas Ehmanns <universeii@gmx.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output
Date: Wed, 6 Jul 2016 18:47:11 +0200 [thread overview]
Message-ID: <577D360F.5090606@gmx.de> (raw)
In-Reply-To: <20160701150415.515459b2@free-electrons.com>
Dear Thomas, Yann, all,
thanks for revising the patch series and for incorporating the changes
into buildroot.
Regards,
Andreas
Am 01.07.2016 um 15:04 schrieb Thomas Petazzoni:
> Hello,
>
> On Fri, 1 Jul 2016 14:36:44 +0200, Yann E. MORIN wrote:
>
>>> @@ -92,6 +98,7 @@ case "$1" in
>>> reload|force-reload)
>>> reload
>>> ;;
>>> +
>> Spurious empty line.
> It's indeed not strictly related, but in all other cases of this
> switch, there is an empty line separating cases. So I think it's good
> to also have this one for consistency. It could have been in a separate
> commit, but oh well, that was good enough.
>
> Thanks for the review!
>
> Thomas
next prev parent reply other threads:[~2016-07-06 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
2016-02-25 21:24 ` [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e' Andreas Ehmanns
2016-07-01 10:10 ` Yann E. MORIN
2016-02-25 21:24 ` [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd Andreas Ehmanns
2016-07-01 12:34 ` Yann E. MORIN
2016-02-25 21:24 ` [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output Andreas Ehmanns
2016-07-01 12:36 ` Yann E. MORIN
2016-07-01 13:04 ` Thomas Petazzoni
2016-07-06 16:47 ` Andreas Ehmanns [this message]
2016-07-01 10:08 ` [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Yann E. MORIN
2016-07-01 13:01 ` Thomas Petazzoni
2016-07-02 10:25 ` Peter Korsgaard
2016-07-02 10:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D360F.5090606@gmx.de \
--to=universeii@gmx.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox