[Buildroot] [PATCH v3 6/6] package/amd-catalyst-driver: Add AMD proprietary graphic stack support

[Romain Perier <romain.perier@free-electrons.com>]

Hello,

Le 26/07/2016 22:39, Yann E. MORIN a ?crit :
>> +	help
>> +	  Installs the OpenCL binary blobs and the ICD profile
>> +	  for GPGPU computing.
>> +
>> +config BR2_PACKAGE_AMD_CATALYST_DRIVER_MODULE_LICENSE_GPL
>> +	bool "fglrx module export GPL license"
>> +	help
>> +	  If enabled, you accept that the driver will be patched locally
>> +	  in order to export itself as a GPL module to the Linux kernel.
>> +	  This is required as the module uses some GPL-compatible
>> +	  symbols. Without this fix, the module won't build properly
>> +	  because the Linux kernel build system does not allow to link a
>> +	  non GPL module, if this one tries to use GPL-only symbols. It
>> +	  is worth mentioning that from a legal point of view, you are
>> +	  most likely not allowed to redistribute such a kernel module,
>> +	  in a pre-built form. The author and the buildroot project
>> +	  disclaim any responsibility in case these terms are not
>> +	  respected.
>
> OK, so this one is definitely a NAK from me. This is definitely not
> acceptable. We can not go like that and just change the licensing
> information: this is legally questionable that we even provide such an
> option, even with the legal blurb you wrote, which is by far not
> explicit enough either, but I won't comment on it because I argue that
> this option should jsut go away with the code it protects.
>
> Instead I suggest the following:
>
>      config BR2_PACKAGE_AMD_CATALYST_DRIVER_MODULE
>          bool "fglrx kernel module"
>          depends on BR2_KERNEL_LINUX
>          depends on whatever is needed
>          help
>            The kernel driver will build properly, but fail to work at
>            runtime because it uses Linux kernel symbols exposed only to
>            GPL-licensed modules.


The problem is that without this local fix, the module *does not* build. 
Because the link phase does not pass. This is why I proposed something 
like that. So, either you merge a package containing a module which 
won't build or you ask the user to patch manually his kernel...

Romain,
-- 
Romain Perier, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com