From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Bedarkar Date: Tue, 4 Oct 2016 18:31:40 +0530 Subject: [Buildroot] [PATCH] elfutils: clarify licensing info In-Reply-To: <1475577852-15870-1-git-send-email-gustavo.zacarias@free-electrons.com> References: <1475577852-15870-1-git-send-email-gustavo.zacarias@free-electrons.com> Message-ID: <57F3A834.6090300@imgtec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi, On Tuesday 04 October 2016 04:14 PM, gustavo.zacarias at free-electrons.com wrote: > From: Gustavo Zacarias > > elfutils libraries are GPLv2 or LGPLv3+, standalone programs are GPLv3+ > (see the NEWS file). > Make the GPLv3+ license tag/file dependant on the programs being > enabled, and make the GPLv2/LGPLv3+ tag more descriptive. > License string should be GPLv2+ instead of GPLv2 because license header uses clause "either version 2 of the License, or (at your option) any later version". With that license string for library is "GPLv2+ or LGPLv3+" > Signed-off-by: Gustavo Zacarias > --- > package/elfutils/elfutils.mk | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/package/elfutils/elfutils.mk b/package/elfutils/elfutils.mk > index 6af1223..5026474 100644 > --- a/package/elfutils/elfutils.mk > +++ b/package/elfutils/elfutils.mk > @@ -8,10 +8,16 @@ ELFUTILS_VERSION = 0.166 > ELFUTILS_SOURCE = elfutils-$(ELFUTILS_VERSION).tar.bz2 > ELFUTILS_SITE = https://fedorahosted.org/releases/e/l/elfutils/$(ELFUTILS_VERSION) > ELFUTILS_INSTALL_STAGING = YES > -ELFUTILS_LICENSE = GPLv3, GPLv2, LGPLv3 > -ELFUTILS_LICENSE_FILES = COPYING COPYING-GPLV2 COPYING-LGPLV3 > +ELFUTILS_LICENSE = GPLv2 or LGPLv3+ (library) As mentioned above it should be ELFUTILS_LICENSE = GPLv2+ or LGPLv3+ (library) > +ELFUTILS_LICENSE_FILES = COPYING-GPLV2 COPYING-LGPLV3 > ELFUTILS_DEPENDENCIES = zlib > > +# Programs are GPLv3+ so add it when they're enabled > +ifeq ($(BR2_PACKAGE_ELFUTILS_PROGS),y) There is same if condition down. Instead we should conditionally add license there. > +ELFUTILS_LICENSE += GPLv3+ (programs) Since it is separate component, it should be comma separated. ELFUTILS_LICENSE := $(ELFUTILS_LICENSE), GPLv3+ (programs) Regards, Rahul