Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten ter Huurne <maarten@treewalker.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] screen: bump to version 4.2.1
Date: Mon, 15 Sep 2014 13:54:05 +0200	[thread overview]
Message-ID: <5832091.sHdIXmaBbS@hyperion> (raw)
In-Reply-To: <1410748789-4094-1-git-send-email-maarten@treewalker.org>

Hi,

The Buildroot package of GNU Screen installs the binary as setuid root; both 
the old (4.0.3) and the new (4.2.1) version do. After having spent some time 
reading the Screen source code, I wouldn't trust it with root privileges on 
any system where security is relevant.

I haven't seen (or looked for) any actual code that could be exploited, just 
a code base that is really old, under-maintained and quite complex from all 
the workarounds it contains. So it resembles the OpenSSL situation, although 
it is not quite that bad.

It seems multiuser mode is the feature that requires Screen to be setuid 
root. Which means that without setuid root, Screen works fine but users can 
only connect to their own sessions.

I would like some guidance on how to proceed here:
- leave the setuid flag on
- always clear the setuid flag post-install
- make it a configuration option
- ...?

Bye,
		Maarten

  reply	other threads:[~2014-09-15 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  2:39 [Buildroot] [PATCH] screen: bump to version 4.2.1 Maarten ter Huurne
2014-09-15 11:54 ` Maarten ter Huurne [this message]
2014-09-15 12:00   ` Baruch Siach
2014-09-15 12:01   ` Thomas Petazzoni
2014-09-21 18:02 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5832091.sHdIXmaBbS@hyperion \
    --to=maarten@treewalker.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox