From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] imx-lib: new package
Date: Mon, 17 Dec 2012 20:40:26 +0100 (CET) [thread overview]
Message-ID: <58636407.1033142.1355773226690.JavaMail.root@advansee.com> (raw)
In-Reply-To: <50CF55F7.9090906@mind.be>
Dear Arnout Vandecappelle,
On Monday, December 17, 2012 6:27:19 PM, Arnout Vandecappelle wrote:
> On 17/12/12 16:57, Beno?t Th?baudeau wrote:
> > Dear Arnout Vandecappelle,
> >
> > On Monday, December 17, 2012 4:50:37 PM, Arnout Vandecappelle
> > wrote:
> >> On 17/12/12 14:48, Arnout Vandecappelle (Essensium/Mind) wrote:
> >>> +IMX_LIB_INCLUDE = \
> >>> + -I$(LINUX_DIR)/drivers/mxc/security/rng/include \
> >>> + -I$(LINUX_DIR)/drivers/mxc/security/sahara2/include \
> >>> + -I$(LINUX_DIR)/include
> >>
> >> Actually, I wonder if this is the right thing to do... This is
> >> a
> >> userspace library that requires a platform-specific linux/xxx.h.
> >> For
> >> an
> >> external toolchain, these headers don't exist in
> >> $(STAGING_DIR)/usr/include/linux
> >>
> >> Directly using $(LINUX_DIR)/include means that the headers are
> >> not
> >> patched for userspace. For those platform-specific headers that's
> >> probably not a problem, but it's not good for e.g. linux/types.h.
> >>
> >> An easy workaround is to use -idirafter instead of -I.
> >> However,
> >> perhaps it's an even better idea to do 'make headers_install' as
> >> part
> >> of
> >> the normal linux build process, so that packages depending on
> >> those
> >> headers can use the patched version. But then again, is it a good
> >> idea to
> >> replace the toolchain's kernel headers with a new set of kernel
> >> headers?
> >>
> >> Any advice is welcome!
> >
> > FYI, I've successfully built the 11.09.01 version under BuildRoot
> > without the
> > "-I$(LINUX_DIR)/include", and the issue that you mention is only
> > for this
> > folder. I had to make a patch to make the headers install work, but
> > that should
> > not be related. Can you try with your package?
>
> ipu/mxc_ipu_hl_lib.h needs linux/mxcfb.h which only exists in the
> imx
> kernels.
I see. I did not have this issue because I have built a custom toolchain based
on Freescale's kernel, so including these headers. This would not be very
practical to impose the use of a custom toolchain here.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-12-17 19:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 13:48 [Buildroot] [PATCH] imx-lib: new package Arnout Vandecappelle
2012-12-17 15:50 ` Arnout Vandecappelle
2012-12-17 15:57 ` Benoît Thébaudeau
2012-12-17 17:27 ` Arnout Vandecappelle
2012-12-17 19:40 ` Benoît Thébaudeau [this message]
2012-12-17 21:49 ` Arnout Vandecappelle
2012-12-17 22:08 ` Benoît Thébaudeau
2012-12-17 16:01 ` Peter Korsgaard
2012-12-17 17:33 ` Arnout Vandecappelle
2012-12-17 20:42 ` Peter Korsgaard
2012-12-17 15:50 ` Benoît Thébaudeau
2012-12-18 10:06 ` Arnout Vandecappelle
2012-12-17 17:42 ` Arnout Vandecappelle
2012-12-17 20:44 ` Peter Korsgaard
2012-12-17 22:01 ` Arnout Vandecappelle
2012-12-17 22:12 ` Benoît Thébaudeau
2012-12-17 22:16 ` Arnout Vandecappelle
2012-12-17 22:49 ` Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58636407.1033142.1355773226690.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox