From: Ricardo Martincoski <ricardo.martincoski@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Restore .git directory in git package downloads
Date: Wed, 19 Apr 2017 20:37:50 -0300 [thread overview]
Message-ID: <58f7f4cee98a1_4789f4cbd048736@ultri3.mail> (raw)
In-Reply-To: 1492574439-4617-1-git-send-email-james@balean.com.au
James,
[Either I or my mail client did something stupid and the e-mail did not reach
the mailing list and the patchwork. Resending to the list]
On Wed, Apr 19, 2017 at 01:00 AM, James Balean wrote:
> +++ b/support/download/git
> @@ -85,10 +85,6 @@ if [ ${recurse} -eq 1 ]; then
> _git submodule update --init --recursive
> fi
>
> -# We do not need the .git dir; we keep other .git files, in case they
> -# are the only files in their directory.
> -rm -rf .git
This patch cannot be applied as-is because:
- it would make the tarballs for git packages not reproducible as the contents
now depend on the state of the remote server (i.e. in some cases a full clone
is needed; assume a tarball is generated, then a new commit is created in the
remote server in any branch, a new full clone with the same reference as
version would include that new commit and therefore the tarball is different);
- it would make the tarballs for git packages much larger (gigabytes for some
linux trees) as they now include the .git directory;
Of course I am not against the discussion looking for another solution.
Regards,
Ricardo
next prev parent reply other threads:[~2017-04-19 23:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 4:00 [Buildroot] [PATCH] Restore .git directory in git package downloads James Balean
2017-04-19 4:15 ` Baruch Siach
2017-04-19 13:01 ` Jan Kundrát
2017-04-19 14:39 ` Andreas Naumann
2017-04-19 20:11 ` Arnout Vandecappelle
2017-04-19 23:37 ` Ricardo Martincoski [this message]
[not found] ` <58f7f1456cc7e_21d33f8c269493f44696f@ultri3.mail>
2017-04-20 3:40 ` Baruch Siach
2017-04-26 3:52 ` James Balean
2017-04-26 4:10 ` Baruch Siach
2017-04-27 17:52 ` Ricardo Martincoski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f7f4cee98a1_4789f4cbd048736@ultri3.mail \
--to=ricardo.martincoski@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox