Re: [Buildroot] [PATCH v3 4/8] package/hare: new host package

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Francois,

Thanks for the update. I have few comments, see below.

On 21/07/2026 11:39, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad.86@gmail.com>
> ---
[...]
> diff --git a/package/hare/hare.mk b/package/hare/hare.mk
> new file mode 100644
> index 000000000..9a85d4c14
> --- /dev/null
> +++ b/package/hare/hare.mk
> @@ -0,0 +1,47 @@
> +################################################################################
> +#
> +# hare
> +#
> +################################################################################
> +
> +HARE_VERSION = 0.26.0.1
> +HARE_SITE = https://git.sr.ht/~sircmpwn/hare/archive
> +HARE_SOURCE = $(HARE_VERSION).tar.gz
> +HARE_LICENSE = MPL-2.0
> +HARE_LICENSE_FILES = COPYING
> +
> +HOST_HARE_DEPENDENCIES = host-harec host-qbe host-scdoc
> +
> +ifeq ($(BR2_aarch64),y)
> +HOST_HARE_TARGET_ARCH = AARCH64
> +else ifeq ($(BR2_RISCV_64),y)
> +HOST_HARE_TARGET_ARCH = RISCV64
> +else ifeq ($(BR2_x86_64),y)
> +HOST_HARE_TARGET_ARCH = X86_64
> +endif
> +
> +HOST_HARE_CONF_OPTS = \
> +	ARCH=$(HOSTARCH) \
> +	DESTDIR="$(HOST_DIR)" \
> +	PREFIX=/usr \
> +	HAREC="$(HOST_DIR)/usr/bin/harec" \
> +	QBE="$(HOST_DIR)/usr/bin/qbe" \
> +	SCDOC="$(HOST_DIR)/usr/bin/scdoc" \
> +	HAREPATH="$(HOST_DIR)/usr/src/hare/stdlib" \

Buildroot decided a long time ago to avoid installing
files in "$(HOST_DIR)/usr/". This is reported by the command:
utils/docker-run make check-package

package/hare/hare.mk:27: install files to $(HOST_DIR)/ instead of 
$(HOST_DIR)/usr/
...

So the previous variables should bechanged to:

        PREFIX=/ \
        HAREC="$(HOST_DIR)/bin/harec" \
        QBE="$(HOST_DIR)/bin/qbe" \
        SCDOC="$(HOST_DIR)/bin/scdoc" \
        HAREPATH="$(HOST_DIR)/src/hare/stdlib" \

Changing those variables will require to updates other packages
in this series. I'll send separate messages.

> +	$(HOST_HARE_TARGET_ARCH)_AS=$(TARGET_AS) \
> +	$(HOST_HARE_TARGET_ARCH)_CC=$(TARGET_CC) \
> +	$(HOST_HARE_TARGET_ARCH)_LD=$(TARGET_LD)
> +
> +define HOST_HARE_CONFIGURE_CMDS
> +	cp $(@D)/configs/linux.mk $(@D)/config.mk
> +endef
> +
> +define HOST_HARE_BUILD_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) $(HOST_HARE_CONF_OPTS) all
> +endef
> +
> +define HOST_HARE_INSTALL_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) $(HOST_HARE_CONF_OPTS) install
> +endef
> +
> +$(eval $(host-generic-package))
> --
> 2.43.0

Could you send and updated series addressing those comments, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot