From: Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] crosstool-ng: add dependency to host-lzma if no lzma found
Date: Fri, 07 Oct 2011 16:51:48 +0200 [thread overview]
Message-ID: <5ce1be6b920b684e152c.1317999108@localhost6.localdomain6> (raw)
Crosstool compilation fails when lzma is not present. If not present on the host
system, we should compile one ourselves.
This patch uses the already existing but seemingly unused check-host-lzma.sh
script in toolchain/dependencies.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
I think the concept of first checking the host system, and only add a host-foo
dependency if needed is a common one. Therefore, I think we should consider
creating a function for it, something used like:
$(if $(call is-host-package-adequate,foo),,host-foo)
This function would return the path to the existing host package, if any, or
the empty string otherwise. The name for such a function is open for discussion
:-)
This mechanism could then be used to check for a recent-enough tar version
(recall from a previous patch series, old tar versions can cause problems when
unpacking archives containing hard-links, if the --strip-components option is
used).
Comments/suggestions are welcome...
diff --git a/package/crosstool-ng/crosstool-ng.mk b/package/crosstool-ng/crosstool-ng.mk
--- a/package/crosstool-ng/crosstool-ng.mk
+++ b/package/crosstool-ng/crosstool-ng.mk
@@ -4,6 +4,6 @@
CROSSTOOL_NG_INSTALL_STAGING = NO
CROSSTOOL_NG_INSTALL_TARGET = NO
CROSSTOOL_NG_MAKE = $(MAKE1)
-HOST_CROSSTOOL_NG_DEPENDENCIES = host-gawk host-automake $(if $(BR2_CCACHE),host-ccache)
+HOST_CROSSTOOL_NG_DEPENDENCIES = host-gawk host-automake $(if $(BR2_CCACHE),host-ccache) $(if $(shell toolchain/dependencies/check-host-lzma.sh),,host-lzma)
$(eval $(call AUTOTARGETS,package,crosstool-ng,host))
next reply other threads:[~2011-10-07 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 14:51 Thomas De Schampheleire [this message]
2011-10-07 18:10 ` [Buildroot] [PATCH] crosstool-ng: add dependency to host-lzma if no lzma found Yann E. MORIN
2011-10-07 18:34 ` Thomas De Schampheleire
2011-10-07 19:43 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce1be6b920b684e152c.1317999108@localhost6.localdomain6 \
--to=patrickdepinguin+buildroot@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox