Re: [Buildroot] [PATCH v5 3/3] board/ti/am64x_sk: add new board

["Gadiyar, Anand via buildroot" <buildroot@buildroot.org>]

> From: Romain Naour <romain.naour@gmail.com>
> 
> Hello Anand,
> 
> Le 23/09/2022 à 22:55, Anand Gadiyar a écrit :
> > From: Xuanhao Shi <x-shi@ti.com>
> >
> > Adds support for ti's am64x_sk board.
> > Adds the configs for generating output sdcard image.
> > Adds the defconfigs for am64x_sk.
> >
> > The AM64x_sk board is designed for the AM642 SoC with
> > two ARM Cortex-A53 and four ARM Cortex-R5. It also
> > supports RJ 45 Ethernet, Wi-Fi, and Bluetooth.
> >
> > More information about the board can be found at:
> > https://www.ti.com/tool/SK-AM64
> >
> > Signed-off-by: Xuanhao Shi <x-shi@ti.com>
> > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---
> >  DEVELOPERS                     |  4 +++
> >  board/ti/am64x_sk/genimage.cfg | 27 +++++++++++++++++++
> >  board/ti/am64x_sk/readme.txt   | 49 ++++++++++++++++++++++++++++++++++
> >  configs/am64x_sk_defconfig     | 45 +++++++++++++++++++++++++++++++
> >  4 files changed, 125 insertions(+)
> >  create mode 100644 board/ti/am64x_sk/genimage.cfg
> >  create mode 100644 board/ti/am64x_sk/readme.txt
> >  create mode 100644 configs/am64x_sk_defconfig
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 81f095f799..121952369c 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -129,8 +129,10 @@ F:	package/libxmlrpc/
> >  F:	package/python-docopt/
> >
> >  N:	Anand Gadiyar <gadiyar@ti.com>
> > +F:	board/ti/am64x_sk/
> >  F:	boot/ti-k3-image-gen/
> >  F:	boot/ti-k3-r5-loader/
> > +F:	configs/am64x_sk_defconfig
> >
> >  N:	André Zwing <nerv@dawncrow.de>
> >  F:	package/libkrb5/
> > @@ -3068,8 +3070,10 @@ N:	Wojciech Niziński <niziak@spox.org>
> >  F:	package/fwup/
> >
> >  N:	Xuanhao Shi <X15000177@gmail.com>
> > +F:	board/ti/am64x_sk/
> >  F:	boot/ti-k3-image-gen/
> >  F:	boot/ti-k3-r5-loader/
> > +F:	configs/am64x_sk_defconfig
> >
> >  N:	Yair Ben Avraham <yairba@protonmail.com>
> >  F:	package/casync/
> > diff --git a/board/ti/am64x_sk/genimage.cfg b/board/ti/am64x_sk/genimage.cfg
> > new file mode 100644
> > index 0000000000..26304fe98f
> > --- /dev/null
> > +++ b/board/ti/am64x_sk/genimage.cfg
> > @@ -0,0 +1,27 @@
> > +image boot.vfat {
> > +	vfat {
> > +		files = {
> > +			"tiboot3.bin",
> > +			"tispl.bin",
> > +			"u-boot.img",
> > +		}
> > +	}
> > +
> > +	size = 16M
> > +}
> > +
> > +image sdcard.img {
> > +	hdimage {
> > +	}
> > +
> > +	partition u-boot {
> > +		partition-type = 0xC
> > +		bootable = "true"
> > +		image = "boot.vfat"
> > +	}
> > +
> > +	partition rootfs {
> > +		partition-type = 0x83
> > +		image = "rootfs.ext4"
> > +	}
> > +}
> > diff --git a/board/ti/am64x_sk/readme.txt b/board/ti/am64x_sk/readme.txt
> > new file mode 100644
> > index 0000000000..8096fcb2d4
> > --- /dev/null
> > +++ b/board/ti/am64x_sk/readme.txt
> > @@ -0,0 +1,49 @@
> > +Texas Instuments AM64x SK Test and Development Board
> > +
> > +Description
> > +===========
> > +
> > +These configurations will build a complete image and
> > +device tree blobs for the the TI AM64x_sk board.
> > +
> > +How to build it
> > +===============
> > +
> > +Select the default configuration for the target:
> > +$ make am64x_sk_defconfig
> > +
> > +Optional: modify the configuration:
> > +$ make menuconfig
> > +
> > +Build:
> > +$ make
> > +
> > +Result of the build:
> > +===================
> > +output/images/
> > ++-- soc
> > ++-- ti-connectivity
> > ++-- bl31.bin
> > ++-- boot.vfat
> > ++-- Image
> > ++-- k3-am642-sk.dtb
> > ++-- r5-u-boot-spl.bin
> > ++-- rootfs.ext2
> > ++-- rootfs.ext4
> > ++-- rootfs.tar
> > ++-- sdcard.img
> > ++-- tee.bin
> > ++-- tee-header_v2.bin
> > ++-- tee-pageable_v2.bin
> > ++-- tee-pager_v2.bin
> > ++-- tiboot3.bin
> > ++-- tispl.bin
> > ++-- u-boot.img
> > +
> > +To copy the image file to the sdcard use dd:
> > +$ dd if=output/images/sdcard.img of=/dev/sdX
> > +
> > +Insert the SDcard into the AM64x_sk board, and power it up with
> > +a USB Type-C connector. The system should come up. You can use
> > +a micro-USB to connect to the connector labled MAIN_UART0 to
> > +communicate with the board.
> > diff --git a/configs/am64x_sk_defconfig b/configs/am64x_sk_defconfig
> > new file mode 100644
> > index 0000000000..1d37b411b3
> > --- /dev/null
> > +++ b/configs/am64x_sk_defconfig
> > @@ -0,0 +1,45 @@
> > +BR2_aarch64=y
> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/ti/am64x_sk/genimage.cfg"
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.19"
> > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="ti/k3-am642-sk"
> > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> > +BR2_PACKAGE_LINUX_FIRMWARE=y
> > +BR2_PACKAGE_LINUX_FIRMWARE_TI_WL18XX=y
> > +BR2_TARGET_ROOTFS_EXT2=y
> > +BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7.0"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="SPD=opteed"
> > +BR2_TARGET_OPTEE_OS=y
> > +BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY=y
> > +BR2_TARGET_OPTEE_OS_PLATFORM="k3"
> > +BR2_TARGET_TI_K3_IMAGE_GEN=y
> > +BR2_TARGET_TI_K3_IMAGE_GEN_SOC="am64x"
> > +BR2_TARGET_TI_K3_IMAGE_GEN_CONFIG="evm"
> > +BR2_TARGET_TI_K3_R5_LOADER_BOARD="am64x_evm"
> > +BR2_TARGET_UBOOT=y
> > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> > +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10-rc1"
> 
> Same comment as for patch 1/3, use a release version if possible.
> 
> I have the sk-tda4vm evaluation board. I'll try to do a runtime test.
> 

Thanks for the review comments Romain!

Will change this - I'll try and resubmit in a few days after 2022.10 is tagged.
2022.07 should work as well, but I haven't built it. Is it better to have the
older version here or the newer one?

The SK-TDA4VM board is for a different TI processor, so the image is not
likely to work for you. I'd love to submit a patch adding support for that
board as well, but I need to check if there are other dependencies (like
the one on firmware that we ran into for the AM62x). We were hoping to
get the AM64x SK supported first as a baseline.

Best Regards,
Anand

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot