Re: [Buildroot] [PATCH 1/1 v2] package/ncmpc: bump version to 0.52

From: Andreas Ziegler <br015@umbiko.net>
To: Tim Soubry <tim.soubry@mind.be>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1 v2] package/ncmpc: bump version to 0.52
Date: Fri, 11 Jul 2025 06:01:49 +0000	[thread overview]
Message-ID: <62efa9f78ee42286cfbd1cc75c7faf5b@umbiko.net> (raw)
In-Reply-To: <mailman.7.1752148801.2060525.buildroot@buildroot.org>

Hi Tim,

On 2025-07-10 11:24, Tim Soubry wrote:
> 
> Applying version bump of ncmpc to version 0.52 as proposed in [1].
> As from version 0.50 of ncmpc, fmt got added as a dependency [2]. This 
> was
> also added to package/ncmpc/Config.in and package/ncmpc/ncmpc.mk.
> 
> For release notes, see:
> https://github.com/MusicPlayerDaemon/ncmpc/blob/master/NEWS
> 
> Comparision between version 0.49 and 0.52:
> https://github.com/MusicPlayerDaemon/ncmpc/compare/v0.49..v0.52
> 
> [1] 
> https://lore.kernel.org/buildroot/20250707112536.1644236-1-tim.soubry@mind.be/T/#rb3b968fff23bac0298e33f473d63a1ad470d38e3
> [2] 
> https://github.com/MusicPlayerDaemon/ncmpc/commit/c3b0055d06f8e8efab7f388646beb7645b90d063
> 
> Signed-off-by: Tim Soubry <tim.soubry@mind.be>
> ---
> v1->v2: Fixed indentation & readded the libatomic dependency for spark
> patch which was previously removed by mistake
>  ...cro-my_gettext-do-not-define-gettext.patch | 199 ------------------
>  package/ncmpc/Config.in                       |   1 +
>  package/ncmpc/ncmpc.hash                      |   2 +-
>  package/ncmpc/ncmpc.mk                        |   3 +-
>  4 files changed, 4 insertions(+), 201 deletions(-)
>  delete mode 100644 
> package/ncmpc/0001-i18n-add-macro-my_gettext-do-not-define-gettext.patch

It seems the libatomic patch needs to be re-based for ncmpc-0.51 due to 
changes in the executable dependencies in meson.build:

>>> ncmpc 0.52 Patching
Applying 0001-meson.build-add-atomic-dependency-for-sparc.patch using 
patch:
patching file meson.build
Hunk #1 succeeded at 231 (offset -1 lines).
Hunk #2 FAILED at 448.
1 out of 2 hunks FAILED -- saving rejects to file meson.build.rej
make[1]: *** [package/pkg-generic.mk:239: 
/home/data/test/autobuild/build/ncmpc-0.52/.stamp_patched] Error 1
make: *** [Makefile:23: _all] Error 2

The autobuild failure that initially made this patch necessary uses a 
rather ancient toolchain:

BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-sparc-uclibc-2018.05.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_6=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_1=y

Since ncmpc from version 0.47 requires C++20 [1] and Buildroot requires 
gcc10 [2], this regression test is now obsolete; newer Sparc toolchains 
seem to handle libatomic without creating an explicit meson dependency.

So you can probably drop this patch.

Kind regards,
Andreas

[1] 
https://github.com/MusicPlayerDaemon/ncmpc/commit/776e97b7a1f99e01d0d93bcbedbdc1736aad8ae6
[2] 
https://gitlab.com/buildroot.org/buildroot/-/commit/d07edd1e4f4e790196bf31f87e071aa9de1cc789
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot