Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/libcppconnman: add new package
Date: Mon, 20 Jul 2026 21:22:52 +0200	[thread overview]
Message-ID: <677b873ff2144474ec7024f39b6496ff@free.fr> (raw)
In-Reply-To: <20260720122202.3073325-1-andrea.ricchi@amarulasolutions.com>

Hi Andrea,

Thanks for the updated patch!

On 20/07/2026 14:22, Andrea Ricchi wrote:
> libcppconnman is a C++ library that provides an easy-to-use API
> to communicate with ConnMan over D-Bus using GDBus.
> 
> https://github.com/amarula/libcppconnman
> 
> Also add myself to DEVELOPERS for this package.
> 
> Signed-off-by: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
> ---
> Changes v2 -> v3:
>   - Config.in: add BR2_TOOLCHAIN_GCC_AT_LEAST_10 dependency (C++20 / 
> <ranges>),
>     fixing build failures on GCC < 10 toolchains reported by the 
> autobuilders
>   - Config.in, libcppconnman.mk: select and depend on readline for the 
> example,
>     fixing the missing readline library configure error when examples 
> are enabled
> 
> Changes v1 -> v2:
>   - add missing libcppconnman entry in package/Config.in
>   - merge the DEVELOPERS addition into this patch
> 
>  DEVELOPERS                               |  1 +
>  package/Config.in                        |  1 +
>  package/libcppconnman/Config.in          | 28 ++++++++++++++++++++++++
>  package/libcppconnman/libcppconnman.hash |  3 +++
>  package/libcppconnman/libcppconnman.mk   | 25 +++++++++++++++++++++
>  5 files changed, 58 insertions(+)
>  create mode 100644 package/libcppconnman/Config.in
>  create mode 100644 package/libcppconnman/libcppconnman.hash
>  create mode 100644 package/libcppconnman/libcppconnman.mk
> 
[...]
> diff --git a/package/libcppconnman/Config.in 
> b/package/libcppconnman/Config.in
> new file mode 100644
> index 0000000000..d99d711e25
> --- /dev/null
> +++ b/package/libcppconnman/Config.in
> @@ -0,0 +1,28 @@
> +config BR2_PACKAGE_LIBCPPCONNMAN
> +	bool "libcppconnman"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 # C++20
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> +	depends on BR2_USE_MMU # libglib2
> +	select BR2_PACKAGE_LIBGLIB2
> +	help
> +	  libcppconnman provide easy to use C++ API to communicate
> +	  with ConnMan via the DBus using GDBus.
> +
> +	  https://amarula.github.io/libcppconnman/
> +
> +comment "libcppconnman needs a toolchain w/ C++20, wchar, threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> +		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_10
> +
> +if BR2_PACKAGE_LIBCPPCONNMAN
> +
> +config BR2_PACKAGE_LIBCPPCONNMAN_EXAMPLE
> +	bool "libcppconnman example"

It seems there is still 2 build failures with the examples. See:
https://gitlab.com/jolivain/buildroot/-/pipelines/2691451879

It is likely due to a missing dependency on BR2_TOOLCHAIN_HAS_SYNC_1.

Could you have a look please?

> +	select BR2_PACKAGE_READLINE
> +	help
> +	  Compile CLI example.
> +
> +endif

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-07-20 19:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 12:22 [Buildroot] [PATCH v3] package/libcppconnman: add new package Andrea Ricchi
2026-07-20 19:22 ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=677b873ff2144474ec7024f39b6496ff@free.fr \
    --to=buildroot@buildroot.org \
    --cc=andrea.ricchi@amarulasolutions.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox