From: bugs at busybox.net <bugs@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [buildroot 0001545]: lsof package configures using host instead of target includes
Date: Sun, 21 Oct 2007 05:03:25 -0700 [thread overview]
Message-ID: <6a941118d0c0db2764eed885402bcfdd@busybox.net> (raw)
The following issue has been CLOSED
======================================================================
http://busybox.net/bugs/view.php?id=1545
======================================================================
Reported By: marcg
Assigned To: buildroot
======================================================================
Project: buildroot
Issue ID: 1545
Category: Other
Reproducibility: always
Severity: minor
Priority: normal
Status: closed
Resolution: open
Fixed in Version:
======================================================================
Date Submitted: 10-20-2007 21:27 PDT
Last Modified: 10-21-2007 05:03 PDT
======================================================================
Summary: lsof package configures using host instead of target
includes
Description:
The lsof package uses its own Configure system, which requires LSOF_INCLUDE
to point to the target's include directory. Without this it defaults to
looking at /usr/include to decide on configuration parameters.
Encountered this where the target didn't have selinux/selinux.h in its
headers, yet lsof's Configure enabled selinux anyway when it found
/usr/include/selinux/selinux.h on the host.
Here's a generic patch that fixes this.
Index: package/lsof/lsof.mk
===================================================================
--- package/lsof/lsof.mk (revision 8)
+++ package/lsof/lsof.mk (working copy)
@@ -10,6 +10,7 @@
LSOF_DIR:=$(BUILD_DIR)/lsof_$(LSOF_VERSION)
LSOF_BINARY:=lsof
LSOF_TARGET_BINARY:=bin/lsof
+LSOF_INCLUDE:=$(STAGING_DIR)/usr/include
BR2_LSOF_CFLAGS:=
ifeq ($(BR2_LARGEFILE),)
@@ -33,7 +34,7 @@
touch $(LSOF_DIR)/.unpacked
$(LSOF_DIR)/.configured: $(LSOF_DIR)/.unpacked
- (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n |
$(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)"
./Configure linux)
+ (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n |
$(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)"
LSOF_INCLUDE="$(LSOF_INCLUDE)" ./Configure linux)
touch $(LSOF_DIR)/.configured
$(LSOF_DIR)/lsof_$(LSOF_VERSION)_src/$(LSOF_BINARY):
$(LSOF_DIR)/.configured
======================================================================
----------------------------------------------------------------------
vanokuten - 10-21-07 05:03
----------------------------------------------------------------------
patch applied in svn r20310, thanks
Issue History
Date Modified Username Field Change
======================================================================
10-20-07 21:27 marcg New Issue
10-20-07 21:27 marcg Status new => assigned
10-20-07 21:27 marcg Assigned To => buildroot
10-21-07 05:03 vanokuten Status assigned => closed
10-21-07 05:03 vanokuten Note Added: 0002853
======================================================================
next reply other threads:[~2007-10-21 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 12:03 bugs at busybox.net [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-21 4:27 [Buildroot] [buildroot 0001545]: lsof package configures using host instead of target includes bugs at busybox.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a941118d0c0db2764eed885402bcfdd@busybox.net \
--to=bugs@busybox.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox