From: Michael Nosthoff via buildroot <buildroot@buildroot.org>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2] package/swupdate: add libubootenv as dependency
Date: Sun, 13 Nov 2022 12:56:33 +0100 [thread overview]
Message-ID: <6cff8-6370db80-5-75c4db80@248833567> (raw)
In-Reply-To: <20221112213244.161b83fe@windsurf>
Hi Thomas,
On Saturday, November 12, 2022 21:32 CET, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Michael,
>
> On Thu, 10 Nov 2022 11:23:12 +0100
> Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
>
> > when using BR2_PER_PACKAGE_DIRECTORIES and configuring swupdate to
> > use uboot the build fails because libubootenv is not a dependency.
> >
> > Fixes:
> > bootloader/uboot.c:23:10: fatal error: libuboot.h: No such file or directory
> > 23 | #include <libuboot.h>
> >
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
>
> Could you provide a bit more details? Your change is only making sure
> libubootenv is built before swupdate *if* libubootenv is eanbled in the
> Buildroot configuration. This would mean libubootenv is an optional
> dependency of swupdate.
>
> But your commit log seems to imply otherwise.
(I just noticed this is also broken when building without PPD if libubootenv is not accidentially built before swupdate)
swupdate has many optional dependencies like libgpiod, libcurl, zstd, zlib (see it's Config.in description).
All off them are not configurable from the buildroot kconfig but from the swupdate config
(see make swupdate-menuconfig). So for all other mentioned optional dependencies there is already
the "if available depend on it" switch set but not for libubootenv.
(Interestingly most of the other dependencies also have a "HAVE_*" configure flag when building swupdate.
For libubootenv I didn't see one.)
To reproduce you just need to add
CONFIG_UBOOT=y
CONFIG_BOOTLOADER_DEFAULT_NONE=y
to package/swupdate/swupdate.config an try to build swupdate.
>
> We are not seeing any build errors on swupdate in our autobuilders.
> Could you provide an example Buildroot configuration that exhibits the
> issue?
Are the autobuilders trying different swupdate-defconfigs? Then this should turn up...
Regards,
Michael
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-13 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:23 [Buildroot] [PATCH v2] package/swupdate: add libubootenv as dependency Michael Nosthoff via buildroot
2022-11-12 20:32 ` Thomas Petazzoni via buildroot
2022-11-13 11:56 ` Michael Nosthoff via buildroot [this message]
2022-11-24 12:36 ` Arnout Vandecappelle
2022-11-27 20:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cff8-6370db80-5-75c4db80@248833567 \
--to=buildroot@buildroot.org \
--cc=buildroot@heine.tech \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox