Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 7] manual: contributing: minor rewording of 'submitting patches' section
Date: Thu, 06 Mar 2014 11:07:32 +0100	[thread overview]
Message-ID: <6e5a7ccaa13faae6b099.1394100452@argentina> (raw)
In-Reply-To: <patchbomb.1394100448@argentina>

This patch makes some minor changes to the section about submitting patches.
Content-wise there are little changes.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Samuel Martin <s.martin49@gmail.com>

---
v2: no changes

 docs/manual/contribute.txt |  20 +++++++++++---------
 1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -164,16 +164,18 @@ Submitting patches
 _Please, do not attach patches to bugs, send them to the mailing list
 instead_.
 
-When your changes are done, and committed in your local git view,
-_rebase_ your development branch on top of the upstream tree before
-generating the patch set. To do so, run:
+If you made some changes to Buildroot and you would like to contribute
+them to the Buildroot project, proceed as follows. Starting from the
+changes committed in your local git view, _rebase_ your development
+branch on top of the upstream tree before generating a patch set. To do
+so, run:
 
 ---------------------
 $ git fetch --all --tags
 $ git rebase origin/master
 ---------------------
 
-Here, you are ready to generate then submit your patch set.
+Now, you are ready to generate then submit your patch set.
 
 To generate it, run:
 
@@ -185,7 +187,7 @@ This will generate patch files in the +o
 automatically adding the +Signed-off-by+ line.
 
 Once patch files are generated, you can review/edit the commit message
-before submitting them using your favorite text editor.
+before submitting them, using your favorite text editor.
 
 Lastly, send/submit your patch set to the Buildroot mailing list:
 
@@ -196,9 +198,9 @@ Lastly, send/submit your patch set to th
 Note that +git+ should be configured to use your mail account.
 To configure +git+, see +man git-send-email+ or google it.
 
-Make sure posted *patches are not line-wrapped*, otherwise they cannot
-easily be applied. In such a case, fix your e-mail client, or better,
-use +git send-email+ to send your patches.
+If you do not use +git send-email+, make sure posted *patches are not
+line-wrapped*, otherwise they cannot easily be applied. In such a case,
+fix your e-mail client, or better yet, learn to use +git send-email+.
 
 Cover letter
 ~~~~~~~~~~~~
@@ -244,7 +246,7 @@ Hereafter the recommended layout:
 ---------------
 Patch title less than 80-character length
 
-Some more paragraph giving some more details.
+A paragraph giving more details.
 
 And yet another paragraph giving more details.
 

  parent reply	other threads:[~2014-03-06 10:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 10:07 [Buildroot] [PATCH 0 of 7] manual: rework Contributing chapter Thomas De Schampheleire
2014-03-06 10:07 ` [Buildroot] [PATCH 1 of 7] manual: contributing: move and expand autobuild section Thomas De Schampheleire
2014-03-06 11:51   ` Samuel Martin
2014-03-06 10:07 ` [Buildroot] [PATCH 2 of 7] manual: contributing: move section on patch reviews up and change intro Thomas De Schampheleire
2014-03-06 11:56   ` Samuel Martin
2014-03-06 10:07 ` [Buildroot] [PATCH 3 of 7] manual: contributing: add section on TODO list Thomas De Schampheleire
2014-03-06 11:58   ` Samuel Martin
2014-03-06 10:07 ` Thomas De Schampheleire [this message]
2014-03-06 10:07 ` [Buildroot] [PATCH 5 of 7] manual: contributing: don't recommend leaving out changelog from patches Thomas De Schampheleire
2014-03-06 11:59   ` Samuel Martin
2014-03-06 10:07 ` [Buildroot] [PATCH 6 of 7] manual: contributing: minor rewording of 'reporting bugs' section Thomas De Schampheleire
2014-03-06 12:02   ` Samuel Martin
2014-03-06 10:07 ` [Buildroot] [PATCH 7 of 7] manual: contributing: modify commit message template Thomas De Schampheleire
2014-03-06 10:10 ` [Buildroot] [PATCH 0 of 7] manual: rework Contributing chapter Thomas De Schampheleire
2014-03-06 17:28 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e5a7ccaa13faae6b099.1394100452@argentina \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox