Re: [Buildroot] [PATCH] package/usbip: new package

From: Julien Olivain <ju.o@free.fr>
To: yann.morin@orange.com
Cc: buildroot@buildroot.org,
	Julien BOIBESSOT <julien.boibessot@armadeus.com>,
	Tal Shorer <tal.shorer@gmail.com>, Marcin Bis <marcin@bis.org.pl>
Subject: Re: [Buildroot] [PATCH] package/usbip: new package
Date: Fri, 27 Dec 2024 13:14:34 +0100	[thread overview]
Message-ID: <700bffe50d1bb2171de3695324f829f2@free.fr> (raw)
In-Reply-To: <adc7c8fecb8ac3010b16178bdad062132dd0d0d8.1734713054.git.yann.morin@orange.com>

Hi Yann,

On 20/12/2024 17:44, yann.morin@orange.com wrote:
> From: "Yann E. MORIN" <yann.morin@orange.com>
> 
> usbip allows configuring a client and a server, to share a USB device
> across the network.
> 
> As explained in the .mk, usbip has been part from the kernel since
> linux-3.17. This would call for making it part of linux-tools, but this
> is a bit unwieldy: usbip is an autotools package, so trying to do a
> proper integration in linux-tools would basically need a complete
> duplication of the autotools infra [0].
> 
> Instead, we decided to go with a full-blown package of its own, that
> just uses the current-latest kernel version. This makes for a nice,
> little autotools package as we like them. Nothing fancy.
> 
> To be noted, though: usbip has its own license and license file, so
> that's what we use, and we do not reference those for the rest of the
> kernel: its GPL-2.0-or-later, not GPL-2.0(-only).
> 
> Finally, we only enable the core usbip support in the kernel, and leave
> it to the user whether they should enable server and/or client support.
> 
> [0] been there, done that; that was ugly and incomplete, what with the
>     libtool patches, autoreconf, and what not.
> 
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> Cc: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> Cc: Tal Shorer <tal.shorer@gmail.com>
> Cc: Marcin Bis <marcin@bis.org.pl>

Applied to master, thanks.

I added a comment in the Config.in about the hwdata/usb.ids package
that is useful (but not mandatory) to this package.

Without it, usbip can show non-fatal error messages such as:

     usbip: error: failed to open /usr/share/hwdata//usb.ids

See:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/tools/usb/usbip/src/usbip_list.c?h=v6.12.6#n341

I also added in Config.in the kernel source directory as the
package homepage:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/tools/usb/usbip

I did that because searching "usbip" in search engines usually gives
the old (pre 3.17 kernel era) homepage:
https://usbip.sourceforge.net/

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot