Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language
Date: Mon, 18 Dec 2017 11:25:11 +0100 (CET)	[thread overview]
Message-ID: <706201859.95242518.1513592711039.JavaMail.root@zimbra32-e6> (raw)
In-Reply-To: <20171218075439.7d3c37c8@windsurf>

Hi!

> On Sun, 17 Dec 2017 18:57:59 +0100, Eric Le Bihan wrote:
> 
> > Eric Le Bihan (9):
> >   rustc: new virtual package
> >   rust-bin: new package
> >   cargo-bin: new package
> >   rust: new package
> 
> This patch didn't make it to the list, because it is too large (2.48
> MB). Do we have another option than carrying this use patch in
> Buildroot ?

The patch which adds the package to build Rust from source provides a 
patch to fix a problem involving files ending with *.orig.

As the Rust compiler is built using Cargo, the tarball contains vendored
versions of the crates (e.g. src/vendor/backtrace-sys). Each crate 
contains a file named Cargo.toml.orig. An associated file named
.cargo-checksum.json will contain a checksum for Cargo.toml.orig (and
the other source files).

But support/scripts/apply-patches.sh will delete the Cargo.toml.orig 
files. This will cause the build to fail, as Cargo will not be able to 
find the file and verify the checksum.

So the patch included in the rust package removes all Cargo.toml.orig 
entries from the affected .cargo-checksum.json. As these files list all
the source files, this results in a huge patch.

Besides, as these are non-indented JSON files, some are one-lined and 
thus the 998 characters limit enforced by git-send-email is exceeded.

So, if there a way to stop support/scripts/apply-patches.sh from pruning
Cargo.toml.orig files, so this patch can be dropped?

Regards,

--
ELB

  reply	other threads:[~2017-12-18 10:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-17 17:57 [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 1/9] rustc: new virtual package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 2/9] rust-bin: new package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 3/9] cargo-bin: " Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 5/9] libssh2: add host variant Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 6/9] libhttpparser: " Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 7/9] libcurl: " Eric Le Bihan
2017-12-18  5:40   ` Baruch Siach
2017-12-27 18:53     ` Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 8/9] cargo: new package Eric Le Bihan
2017-12-17 17:58 ` [Buildroot] [PATCH 9/9] rust-cargo: new virtual package Eric Le Bihan
2017-12-17 18:17 ` [Buildroot] [PATCH v8 0/9] Add support for the Rust programming language Eric Le Bihan
2017-12-18  6:54 ` Thomas Petazzoni
2017-12-18 10:25   ` Eric Le Bihan [this message]
2017-12-18 10:31     ` Thomas Petazzoni
2017-12-18 15:26       ` Yann E. MORIN
2017-12-18 10:49     ` Eric Le Bihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=706201859.95242518.1513592711039.JavaMail.root@zimbra32-e6 \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox