Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugs at busybox.net <bugs@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [buildroot 0000944]: Some portability fixes for running on a MacOSX host
Date: Wed, 11 Jul 2007 11:52:27 -0700	[thread overview]
Message-ID: <707bfb87cab2ca74d3b9725ccffbd4b2@busybox.net> (raw)


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=944 
====================================================================== 
Reported By:                wiml
Assigned To:                buildroot
====================================================================== 
Project:                    buildroot
Issue ID:                   944
Category:                   Other
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             07-12-2006 23:48 PDT
Last Modified:              07-11-2007 11:52 PDT
====================================================================== 
Summary:                    Some portability fixes for running on a MacOSX host
Description: 
This patch addresses a few minor linuxisms or (non-BSD)isms in buildroot's
shell scripts.

1. Replaces "cp -a" with "cp -pPR". "-a" is just a conveinence for -pPR,
and none of the BSD-derived systems I've checked have it.

2. My 'sed' reqires an explicit empty string after -i, or else it will use
the "-e" arg as the extension for backups. Oops.

3. My 'sed' requires an EOL or semicolon before the closing curly in a
{foo...} construct.

4. Apple's GCC prints a version string that dependencies.sh can't handle.
This change removes any parenthesized bits from the version string before
looking for numbers, so it can handle version strings like
    powerpc-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc.
build 5250)

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0001251 Buildroot uses lots of cp commands that...
====================================================================== 

---------------------------------------------------------------------- 
 bernhardf - 12-22-06 04:30  
---------------------------------------------------------------------- 
1) I'd rather prefer if you could expand the host-sed check so we build a
working sed for your system.
2) That cp -a patch looks ok. For files, we usually (try to) use "cp
-dpf", so please use -dpf resp. -Rdpf
  Please attach a new split patch with just the cp changes.
3) I think that the current dependencies.sh should deal with this, please
verify.

Thanks in advance for attaching updated, separate patches that take the
comments above into account.
cheers,
Bernhard 

---------------------------------------------------------------------- 
 bernhardf - 07-07-07 11:51  
---------------------------------------------------------------------- 
To be flexible, i suggest we add
ifeq (linux)
CP_A:=cp -a
endif
ifeq (apple or bsd)
CP_A:=cp ...
endif

variants for "force" "recurse" should be provided. 

---------------------------------------------------------------------- 
 chickenandporn - 07-11-07 07:36  
---------------------------------------------------------------------- 
Is there a platform that "cp -fPpR" doesn't work on?  Most platforms mimick
the old svr4.2r3.2 behavior, or the 4.0r3.0 that migrated from AT&T to BSD,
as a bare minimum, right?

I point this out because the following:

xxx: yyyy
     cp -fPpR dir1 dir2

...is easier to read than:

xxx: yyyy
     $(SOME_BIG_MACRO) dir1 dir2

OK, it might be easier than I am presenting, but if the base behavior is
acceptible, and we're used to reading unix commands, it's easier to read
if the changes are just made to be the most portable form of commands. 

---------------------------------------------------------------------- 
 holin - 07-11-07 11:52  
---------------------------------------------------------------------- 
Try older OS X (10.2), older busybox versions, maybe older BSDs and less
common Unix flavors, such as IRIX, HP-UX, and wherever cross-gcc may
build. Technically, the POSIX -R is suboptimal substitute to the GNU -d
that's used all over to copy symbolic links, but that's about it in the
gravely missed features section. Anywhoo, I'd be all for changing to POSIX
syntax, too, because that's at least a larger common denominator than
GNU... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-12-06 23:48  wiml           New Issue                                    
07-12-06 23:48  wiml           Status                   new => assigned     
07-12-06 23:48  wiml           Assigned To               => uClibc          
07-12-06 23:48  wiml           File Added: buildroot1.patch                    
12-22-06 04:30  bernhardf      Note Added: 0001914                          
12-22-06 04:30  bernhardf      Status                   assigned => feedback
02-12-07 05:34  vapier         Status                   feedback => assigned
02-12-07 05:34  vapier         Assigned To              uClibc => buildroot 
07-07-07 11:46  bernhardf      Relationship added       has duplicate 0001251
07-07-07 11:51  bernhardf      Note Added: 0002559                          
07-11-07 07:36  chickenandporn Note Added: 0002589                          
07-11-07 11:52  holin          Note Added: 0002590                          
======================================================================

             reply	other threads:[~2007-07-11 18:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11 18:52 bugs at busybox.net [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-11 19:22 [Buildroot] [buildroot 0000944]: Some portability fixes for running on a MacOSX host bugs at busybox.net
2007-07-11 14:36 bugs at busybox.net
2007-07-07 18:51 bugs at busybox.net
2007-07-07 18:46 bugs at busybox.net
2007-02-12 13:34 bugs at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=707bfb87cab2ca74d3b9725ccffbd4b2@busybox.net \
    --to=bugs@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox