Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] kmod: really pass --disable-manpages
Date: Sun, 09 Feb 2014 10:11:06 +0100	[thread overview]
Message-ID: <7291a6ec-9696-4801-936d-fdab0d43bcdf@email.android.com> (raw)
In-Reply-To: <20140209083628.E9C0D9C8B1@busybox.osuosl.org>

Peter Korsgaard <peter@korsgaard.com> schreef:
>commit: http://git.buildroot.net/buildroot/commit/?id=674fd4f83464a1449a0db8bb4e2584b7b6f6a051
>branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
>The line below overwrites KMOD_CONF_OPT, so move the --disable-manpages
>options below.
>
>Fixes http://autobuild.buildroot.net/results/842/842131307c171e1bc5a1e918996d53b00ddb1be3/
>
>Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>---
> package/kmod/kmod.mk |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
>index f819d0e..f79a492 100644
>--- a/package/kmod/kmod.mk
>+++ b/package/kmod/kmod.mk
>@@ -15,13 +15,13 @@ HOST_KMOD_DEPENDENCIES = host-pkgconf
> KMOD_LICENSE = LGPLv2.1+
> KMOD_LICENSE_FILES = libkmod/COPYING
> 
>-KMOD_CONF_OPT += --disable-manpages
>-HOST_KMOD_CONF_OPT = --disable-manpages
>-
> # static linking not supported, see
> # https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
> KMOD_CONF_OPT = --disable-static --enable-shared
> 
>+KMOD_CONF_OPT += --disable-manpages
>+HOST_KMOD_CONF_OPT = --disable-manpages
>+
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> KMOD_DEPENDENCIES += zlib
> KMOD_CONF_OPT += --with-zlib

Aargh, another oops, sorry.
Isn't it safer to always use += for this type of variables?

Best regards,
Thomas

  reply	other threads:[~2014-02-09  9:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09  8:35 [Buildroot] [git commit] kmod: really pass --disable-manpages Peter Korsgaard
2014-02-09  9:11 ` Thomas De Schampheleire [this message]
2014-02-09  9:17   ` Peter Korsgaard
2014-02-10 17:10     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7291a6ec-9696-4801-936d-fdab0d43bcdf@email.android.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox