From: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
To: buildroot@busybox.net
Subject: [Buildroot] [RCF 1/2] support: enforce '--binary' when applying patches
Date: Thu, 29 Sep 2016 13:11:04 -0300 (BRT) [thread overview]
Message-ID: <764549583.350082.1475165464533.JavaMail.zimbra@datacom.ind.br> (raw)
In-Reply-To: <20160929145701.27116-1-james.knight@rockwellcollins.com>
James,
This change can have issues with old distros, see below.
Currently buildroot does not enforce a minimal version of 'patch'.
----- Original Message -----
> From: "James Knight" <james.knight@rockwellcollins.com>
> To: buildroot at busybox.net
> Cc: "James Knight" <james.knight@rockwellcollins.com>
> Sent: Thursday, September 29, 2016 11:57:00 AM
> Subject: [Buildroot] [RCF 1/2] support: enforce '--binary' when applying patches
> The following commit enforces the patch operation to "disable the
> heuristic for transforming CRLF line endings into LF line endings" [1].
[snip]
So I think you need a version of the tool 'patch' that contains [3]
that was merged in patch v2.6
RHEL5 and RHEL4 use patch v2.5.4.
> [1]: http://git.savannah.gnu.org/cgit/patch.git/tree/patch.man#n306
> [2]: https://www.gnu.org/software/diffutils/manual/html_node/Binary.html
[snip]
[3] http://git.savannah.gnu.org/cgit/patch.git/commit/?id=b7687446d1e7673a39fd66bc6043f4a78961f675
Regards,
Ricardo Martincoski
next prev parent reply other threads:[~2016-09-29 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 14:57 [Buildroot] [RCF 1/2] support: enforce '--binary' when applying patches James Knight
2016-09-29 14:57 ` [Buildroot] [RCF 2/2] rapidxml: add patch to fix usage with gcc 4.7+ James Knight
2016-09-29 16:11 ` Ricardo Martincoski [this message]
2016-09-29 17:22 ` [Buildroot] [RCF 1/2] support: enforce '--binary' when applying patches James Knight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764549583.350082.1475165464533.JavaMail.zimbra@datacom.ind.br \
--to=ricardo.martincoski@datacom.ind.br \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox