Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: buildroot@busybox.net
Subject: [Buildroot] libmad and AVR32 optimisations
Date: Thu, 21 Feb 2013 00:14:23 +0100 (CET)	[thread overview]
Message-ID: <771436318.25518.1361402063381.JavaMail.root@advansee.com> (raw)
In-Reply-To: <CAKcgs2zty=9pybVT7FwDMmSK0omc1x9tgwmDkgiMbixjFkv-oA@mail.gmail.com>

Dear Gilles,

On Wednesday, February 20, 2013 11:58:29 PM, Gilles Talis wrote:
> All,

> There is small issue in the AVR32 optimization patch [1]. This is root cause
> for autobuild failures: e01f5a5484299dce1797966445f3972583c67b22 and
> 7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d.

> Reason is that some fixed-point math routines are implemented in
> architecture-specific files. If "architecture-specific optimizations" option
> is disabled from the build configuration, these routines are not compiled,
> but libmad is built with references to these functions though.

> My question is: is this issue worth fixing? I assume that libmad users will
> usually enable all possible architecture-specific optimizations.

> Thanks
> Gilles.

> [1] package/libmad/libmad-0.15.1b-optimization.patch.avr32

This patch was clearly made for specific libmad settings. Rather than fixing it,
it would be easier to simply add a "depends on !BR2_avr32" to the config options
that fail on AVR32.

Best regards,
Beno?t

  reply	other threads:[~2013-02-20 23:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 22:58 [Buildroot] libmad and AVR32 optimisations Gilles Talis
2013-02-20 23:14 ` Benoît Thébaudeau [this message]
     [not found]   ` <CAKcgs2wW-vj=1NENE0mLmaZjwD6z9MrhzVm4aScnuX1f7COToQ@mail.gmail.com>
2013-02-21  0:55     ` Benoît Thébaudeau
2013-02-21  1:48       ` Gilles Talis
2013-02-21 10:33   ` Peter Korsgaard
2013-02-21 10:52     ` Simon Dawson
2013-02-21 10:58       ` Peter Korsgaard
2013-02-21 12:28         ` Benoît Thébaudeau
2013-02-21 12:42           ` Peter Korsgaard
2013-02-21 19:36             ` Simon Dawson
2013-02-21 20:39               ` Peter Korsgaard
2013-02-22  1:03                 ` Gilles Talis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=771436318.25518.1361402063381.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox