Re: [Buildroot] [PATCH 1/1] boot/grub2: needs host-python3

[Julien Olivain <ju.o@free.fr>]

Hi Peter, All,

On 21/09/2024 10:18, Peter Korsgaard wrote:
>>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> 
>  > When the build host does not have a Python interpreter installed,
>  > host-grub2 is failing to configure due to this missing interpreter.
>  > Note that host-grub2 is the first package to fail because it is a
>  > dependency of grub2. The grub2 target package has the same 
> dependency
>  > requirement.
> 
>  > The issue can be quickly reproduced on a host without Python with 
> the
>  > commands:
> 
>  >     cat <<EOF >.config
>  >     BR2_aarch64=y
>  >     BR2_TARGET_GRUB2=y
>  >     BR2_TOOLCHAIN_EXTERNAL=y
>  >     EOF
>  >     make olddefconfig
>  >     make grub2
> 
>  > grub2 autotools configure.ac search for a Python interpreter since
>  > upstream commit [1] 8b467844e "python: Use AM_PATH_PYTHON to 
> determine
>  > interpreter for gentpl.py", first included in grub v2.04 released
>  > on 2019-07-04. For reference, grub2 has been updated to that version
>  > in commit [2] ea7ec41c "boot/grub2: bump to verson 2.04".
> 
>  > This commit fixes the issue by adding the host-python3 dependency to
>  > host-grub2 and grub2.
> 
>  > Fixes:
> 
>  >     checking for a Python interpreter with version >= 2.6... none
>  >     configure: error: no suitable Python interpreter found
> 
>  > [1] 
> https://git.savannah.gnu.org/gitweb/?p=grub.git;a=commitdiff;h=8b467844e11170077c8ca727c39d2bd36eeb5f08
>  > [2] 
> https://gitlab.com/buildroot.org/buildroot/-/commit/ea7ec41cf64e86a692ac45e0d012c6e8199ef110
> 
>  > Reported-by: Vincent Stehlé <vincent.stehle@arm.com>
>  > Signed-off-by: Julien Olivain <ju.o@free.fr>
> 
> Given that it apparently doesn't need any special python modules could
> we use $(BR2_PYTHON3_HOST_DEPENDENCY) instead to only build python3 if
> not available on the host / older than 3.4?

Yes, I confirm that for now, there is no specific python module
requirement, and Python 3.4 should also be sufficient. So we could
switch to BR2_PYTHON3_HOST_DEPENDENCY to save the time of the host
python build.

The same comment applies to the Linux kernel.

Since those patches were recently merged in [1] and [2], I'll propose
followup patches as an improvement.

> --
> Bye, Peter Korsgaard

Best regards,

Julien.

[1] 
https://gitlab.com/buildroot.org/buildroot/-/commit/86bb1b2360bdaed069cd087541f4edad1d5ce925
[2] 
https://gitlab.com/buildroot.org/buildroot/-/commit/abce4a2b365276a7fa081d327289e5e6d8bdca7e
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot