Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ziegler <br025@umbiko.net>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package
Date: Sat, 06 Dec 2025 05:18:25 +0000	[thread overview]
Message-ID: <7ca4bb66f110e9ea76010831f7c040f0@umbiko.net> (raw)
In-Reply-To: <20251205193057.1884663-1-bernd@kuhls.net>

Hi Bernd, Thomas, all

On 2025-12-05 19:30, Bernd Kuhls wrote:
> Replaces libsidplay2 as dependency in mpd 0.24.0:
> https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
> https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9

Apart from mpd, there are only two other packages depending on 
libsidplay2:

~/buildroot$ grep libsidplay2 package/*/*.mk
package/kodi-audiodecoder-sidplay/kodi-audiodecoder-sidplay.mk:KODI_AUDIODECODER_SIDPLAY_DEPENDENCIES 
= host-pkgconf kodi libsidplay2
package/libsidplay2/libsidplay2.mk:# libsidplay2
package/mpd/mpd.mk:MPD_DEPENDENCIES += libsidplay2
package/vlc/vlc.mk:VLC_DEPENDENCIES += libsidplay2

Should we patch them and drop libsidplay2 completely? Libsidplayfp seems 
to be better maintaned. I can offer help.

> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/Config.in                      |  1 +
>  package/libsidplayfp/Config.in         | 13 +++++++++++++
>  package/libsidplayfp/libsidplayfp.hash |  3 +++
>  package/libsidplayfp/libsidplayfp.mk   | 20 ++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/libsidplayfp/Config.in
>  create mode 100644 package/libsidplayfp/libsidplayfp.hash
>  create mode 100644 package/libsidplayfp/libsidplayfp.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 92b72194e3..1c80b779fc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1559,6 +1559,7 @@ menu "Audio/Sound"
>  	source "package/libreplaygain/Config.in"
>  	source "package/libsamplerate/Config.in"
>  	source "package/libsidplay2/Config.in"
> +	source "package/libsidplayfp/Config.in"
>  	source "package/libsilk/Config.in"
>  	source "package/libsndfile/Config.in"
>  	source "package/libsoundtouch/Config.in"
> diff --git a/package/libsidplayfp/Config.in 
> b/package/libsidplayfp/Config.in
> new file mode 100644
> index 0000000000..43841173b1
> --- /dev/null
> +++ b/package/libsidplayfp/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBSIDPLAYFP
> +	bool "libsidplayfp"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  libsidplayfp is a C64 music player library which integrates
> +	  the reSID SID chip emulation into a cycle-based emulator
> +	  environment, constantly aiming to improve emulation of the
> +	  C64 system and the SID chips.
> +
> +	  https://github.com/libsidplayfp/libsidplayfp
> +
> +comment "libsidplayfp needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsidplayfp/libsidplayfp.hash 
> b/package/libsidplayfp/libsidplayfp.hash
> new file mode 100644
> index 0000000000..880c31ee28
> --- /dev/null
> +++ b/package/libsidplayfp/libsidplayfp.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  
> 7c6ab283fda53d34973fa266fc3809e16964dd8ccb7edcc11516ef5e3f66b3cd  
> libsidplayfp-2.15.2.tar.gz
> +sha256  
> 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  
> COPYING
> diff --git a/package/libsidplayfp/libsidplayfp.mk 
> b/package/libsidplayfp/libsidplayfp.mk
> new file mode 100644
> index 0000000000..3aeeb19013
> --- /dev/null
> +++ b/package/libsidplayfp/libsidplayfp.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# libsidplayfp
> +#
> +################################################################################
> +
> +LIBSIDPLAYFP_VERSION = 2.15.2
> +LIBSIDPLAYFP_SITE = 
> https://github.com/libsidplayfp/libsidplayfp/releases/download/v$(LIBSIDPLAYFP_VERSION)
> +LIBSIDPLAYFP_LICENSE = GPL-2.0+
> +LIBSIDPLAYFP_LICENSE_FILES = COPYING
> +LIBSIDPLAYFP_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
> +LIBSIDPLAYFP_CONF_OPTS += --with-gcrypt
> +LIBSIDPLAYFP_DEPENDENCIES += libgcrypt
> +else
> +LIBSIDPLAYFP_CONF_OPTS += --without-gcrypt
> +endif
> +
> +$(eval $(autotools-package))
> --
> 2.47.3

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-12-06  5:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 19:30 [Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package Bernd Kuhls
2025-12-05 19:30 ` [Buildroot] [PATCH/next 2/2] package/mpd: switch from libsidplay2 to libsidplayfp Bernd Kuhls
2025-12-06  4:51   ` Andreas Ziegler
2025-12-05 19:35 ` [Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package Thomas Petazzoni via buildroot
2025-12-06  5:18 ` Andreas Ziegler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ca4bb66f110e9ea76010831f7c040f0@umbiko.net \
    --to=br025@umbiko.net \
    --cc=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox