From: Julien Olivain <ju.o@free.fr>
To: patrick.oppenlander@gmail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/minisign: bump to version 0.12
Date: Fri, 24 Jan 2025 21:29:38 +0100 [thread overview]
Message-ID: <81e6726e7ebcce7cbf78df44fafe366a@free.fr> (raw)
In-Reply-To: <20250121031414.5907-1-patrick.oppenlander@gmail.com>
Hi Patrick,
Thanks for the patch.
On 21/01/2025 04:14, patrick.oppenlander@gmail.com wrote:
> From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Could you add a link to the change log in the commit log, please?
Something like:
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Also, reading it, I see that the libsodium is now an optional
dependency.
Do you think it is worth reflecting this change in the Buildroot recipe?
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> ---
> package/minisign/minisign.hash | 2 +-
> package/minisign/minisign.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/minisign/minisign.hash
> b/package/minisign/minisign.hash
> index 12cde42a43..74941163e9 100644
> --- a/package/minisign/minisign.hash
> +++ b/package/minisign/minisign.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> -sha256
> 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55
> minisign-0.11.tar.gz
> +sha256
> 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0
> minisign-0.12.tar.gz
> sha256
> d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
> LICENSE
Running "make minisign-legal-info" fails with output:
>>> minisign 0.12 Collecting legal info
ERROR: while checking hashes from package/minisign/minisign.hash
ERROR: LICENSE has wrong sha256 hash:
ERROR: expected:
d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
ERROR: got :
01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
Could you check what has changed in the license (you can provide a link
to the
upstream commit change, or describe the change) and send an updated
version of
this patch?
Best reagrds,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-01-24 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 3:14 [Buildroot] [PATCH] package/minisign: bump to version 0.12 patrick.oppenlander
2025-01-24 20:29 ` Julien Olivain [this message]
2025-01-27 4:42 ` Patrick Oppenlander
2025-01-27 22:15 ` [Buildroot] [PATCH v2] " patrick.oppenlander
2025-01-27 23:32 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81e6726e7ebcce7cbf78df44fafe366a@free.fr \
--to=ju.o@free.fr \
--cc=buildroot@buildroot.org \
--cc=patrick.oppenlander@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox