From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Naour Date: Sat, 3 Oct 2020 21:40:15 +0200 Subject: [Buildroot] [PATCH v2, 1/1] package/supertux: fix build with RELRO In-Reply-To: <87zh58y9vb.fsf@dell.be.48ers.dk> References: <20200914203329.3432074-1-fontaine.fabrice@gmail.com> <87zh58y9vb.fsf@dell.be.48ers.dk> Message-ID: <8227afb0-d29f-4ab8-93b2-eef84ccfd0da@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Fabrice, Le 29/09/2020 ? 15:45, Peter Korsgaard a ?crit?: >>>>>> "Fabrice" == Fabrice Fontaine writes: > > > Disable static building of external/squirrel to fix the following build > > failure with RELRO: > > > /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: > > CMakeFiles/sq_static.dir/sq.c.o: relocation R_X86_64_32 against > > `.rodata.str1.8' can not be used when making a PIE object; recompile > > with -fPIC > > /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: > > final link failed: nonrepresentable section on output > > collect2: error: ld returned 1 exit status > > > Fixes: > > - http://autobuild.buildroot.org/results/46e8f5e622ce450a89bc6d70f4bfd38182557901 > > - http://autobuild.buildroot.org/results/a43720492d817e4555d728546da9114e3ccba952 > > > Signed-off-by: Fabrice Fontaine > > --- > > Changes v1 -> v2 (after review of Thomas Petazzoni): > > - Disable static building of external/squirrel instead of adding -fPIC > > Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks. > This patch break supertux because libsquirrel.so.0 and libsqstdlib.so.0 are missing in TARGET_DIR. I believe, such bundled libraries are meant to be linked statically into supertux. We need to revert this patch. Best regards, Romain