Re: [Buildroot] [PATCH v4 1/3] board/andes: rearrange andes folder structure

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi Peter,

On 23/02/22 08:10, Yu Chien Peter Lin wrote:
> Rename ae3xx to ae300 for nds32 architecture and add ae350 platform.
> 
> AE300 (NDS32):
> - http://www.andestech.com/en/products-solutions/andeshape-platforms/ae300/
> AE350 (RISC-V):
> - http://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/
> 
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> Signed-off-by: Alan Kao <alankao@andestech.com>
> ---
> Changes v1 -> v2:
>     - move linux source code and its patches to AndesTech Github repo
>     - rename ae350_andestar45_defconfig to andes_ae350_45_defconfig
>     - change C library to uClibc
>     - remove OpenSSL package
>     - remove rootfs.cpio and rootfs.tar
>     - update DEVELOPERS
> Changes v2 -> v3:
>     - specifiy branch to download from AndesTech linux repo
>     - change boot.cmd to extlinux.conf
>     - add post-build.sh for extlinux.conf to retrieve Image and DTB
>     - fix format and update genimage_sdcard.cfg
>     - update readme.txt
>     - add packages (python3, pylibfdt and openssl) for u-boot binman
>     - reorder item in DEVELOPERS
> Changes v3 -> v4:
>     - rename ae3xx folder to ae300
>     - rename andes_ae3xx_defconfig to andes_ae300_defconfig
>     - update readme.txt and item in DEVELOPERS

Some of these change ^^^ must have been moved to the single patch, like 
DEVELOPERS is updated in patch 3/3. I've also forgotten to point you to 
add a --cover-letter, so keep in mind both points for next time.

I've built tested both defconfig successfully, so:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
[Giulio: build tested only]

And the other patches of this series is all reviewed, so to me it's 
ready to be committed, but this will happen after Buildroot 2022.02 is 
released, since between rc1 to the release Maintainers only accept 
fixes. Another possibility is that they will commit these patches to 
next branch.

Please remember to tag V3.

Thank you for your effort!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> ---
>   .../{ae3xx/ae3xx.fragment => ae300/ae300.fragment}     |  0
>   .../linux/0001-nds32-Fix-boot-messages-garbled.patch   |  0
>   ...-dtc-Remove-redundant-YYLOC-global-declaratio.patch |  0
>   board/andes/{ => ae300}/readme.txt                     | 10 +++++-----
>   .../{andes_ae3xx_defconfig => andes_ae300_defconfig}   |  4 ++--
>   .../toolchain-external-andes-nds32/Config.in           |  2 +-
>   6 files changed, 8 insertions(+), 8 deletions(-)
>   rename board/andes/{ae3xx/ae3xx.fragment => ae300/ae300.fragment} (100%)
>   rename board/andes/{ => ae300}/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch (100%)
>   rename board/andes/{ => ae300}/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch (100%)
>   rename board/andes/{ => ae300}/readme.txt (71%)
>   rename configs/{andes_ae3xx_defconfig => andes_ae300_defconfig} (69%)
> 
> diff --git a/board/andes/ae3xx/ae3xx.fragment b/board/andes/ae300/ae300.fragment
> similarity index 100%
> rename from board/andes/ae3xx/ae3xx.fragment
> rename to board/andes/ae300/ae300.fragment
> diff --git a/board/andes/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch b/board/andes/ae300/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> similarity index 100%
> rename from board/andes/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> rename to board/andes/ae300/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> diff --git a/board/andes/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch b/board/andes/ae300/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> similarity index 100%
> rename from board/andes/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> rename to board/andes/ae300/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> diff --git a/board/andes/readme.txt b/board/andes/ae300/readme.txt
> similarity index 71%
> rename from board/andes/readme.txt
> rename to board/andes/ae300/readme.txt
> index 0f95c65549..51c05c9235 100644
> --- a/board/andes/readme.txt
> +++ b/board/andes/ae300/readme.txt
> @@ -1,10 +1,10 @@
>   Intro
>   =====
>   
> -Andestech(nds32) AE3XX Platform
> +Andestech(nds32) AE300 Platform
>   
> -The AE3XX prototype demonstrates the AE3XX example platform on the FPGA.
> -It is composed of one Andestech(nds32) processor and AE3XX.
> +The AE300 prototype demonstrates the AE300 example platform on the FPGA.
> +It is composed of one Andestech(nds32) processor and AE300.
>   
>   How to build it
>   ===============
> @@ -12,10 +12,10 @@ How to build it
>   Configure Buildroot
>   -------------------
>   
> -The andes_ae3xx_defconfig configuration is a sample configuration with
> +The andes_ae300_defconfig configuration is a sample configuration with
>   all that is required to bring the FPGA Development Board:
>   
> -  $ make andes_ae3xx_defconfig
> +  $ make andes_ae300_defconfig
>   
>   Build everything
>   ----------------
> diff --git a/configs/andes_ae3xx_defconfig b/configs/andes_ae300_defconfig
> similarity index 69%
> rename from configs/andes_ae3xx_defconfig
> rename to configs/andes_ae300_defconfig
> index 52634caa50..ffcb4d7d38 100644
> --- a/configs/andes_ae3xx_defconfig
> +++ b/configs/andes_ae300_defconfig
> @@ -1,10 +1,10 @@
>   BR2_nds32=y
> -BR2_GLOBAL_PATCH_DIR="board/andes/patches/"
> +BR2_GLOBAL_PATCH_DIR="board/andes/ae300/patches"
>   BR2_TOOLCHAIN_EXTERNAL=y
>   BR2_TOOLCHAIN_EXTERNAL_ANDES_NDS32=y
>   BR2_LINUX_KERNEL=y
>   BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>   BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.17"
>   BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> -BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/andes/ae3xx/ae3xx.fragment"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/andes/ae300/ae300.fragment"
>   BR2_TARGET_ROOTFS_INITRAMFS=y
> diff --git a/toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in b/toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in
> index 9c937b8c44..ecd50cc805 100644
> --- a/toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in
> +++ b/toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in
> @@ -12,4 +12,4 @@ config BR2_TOOLCHAIN_EXTERNAL_ANDES_NDS32
>   	help
>   	  nds32 toolchain for the nds32 architecture. It uses GCC
>   	  8.2.1, GDB 8.1.1, glibc 2.28, Binutils 2.30. It generates
> -	  code that runs on ae3xx platform
> +	  code that runs on ae300 platform

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot