From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Devoogdt <thomas@devoogdt.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
yann.morin.1998@free.fr
Subject: Re: [Buildroot] [PATCH v2] package/libglib2: fix libiconv (intl) support
Date: Fri, 01 Mar 2024 11:52:46 +0100 [thread overview]
Message-ID: <871q8u9qbl.fsf@48ers.dk> (raw)
In-Reply-To: <20240207171034.535dd392@windsurf> (Thomas Petazzoni via buildroot's message of "Wed, 7 Feb 2024 17:10:34 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Sun, 14 Jan 2024 19:41:11 +0100
> Thomas Devoogdt <thomas@devoogdt.com> wrote:
>> Libglib2 can compile without localization support,
>> but still depends on libiconv, which is selected in Config.in.
>>
>> This fallback support was broken, and is fixed in this upstream commit:
>> https://gitlab.gnome.org/GNOME/glib/-/commit/a497d5be122f193dcf8679334308333bbbc14a71
>>
>> The other patch is purely added to avoid merge conflicts while cherry-picking.
>>
>> Fixes: http://autobuild.buildroot.org/results/04d/04d9a17e64503e0bece7bad33549ef3ad4b237c9/build-end.log.
>>
>> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
>> ---
>> v2: dropped meson libintl wrap, problem was the libiconv detection
>> ---
>> ...ion-of-a-system-provided-proxy-libin.patch | 53 +++++++++++++++++++
>> ...05-meson-try-iconv-in-libintl-lookup.patch | 53 +++++++++++++++++++
>> 2 files changed, 106 insertions(+)
>> create mode 100644 package/libglib2/0004-meson-Fix-detection-of-a-system-provided-proxy-libin.patch
>> create mode 100644 package/libglib2/0005-meson-try-iconv-in-libintl-lookup.patch
> Applied to master after doing some research to explain when the problem
> was introduced, so that Peter can more easily decide if this should be
> backported, and to which branches.
Thanks for that, so from that description I take it that only 2023.11.x
is affected?
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-01 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 18:37 [Buildroot] [PATCH v1] package/libglib2: fix libintl support Thomas Devoogdt
2024-01-14 12:02 ` Yann E. MORIN
2024-01-14 18:00 ` Thomas Devoogdt
2024-01-14 18:41 ` [Buildroot] [PATCH v2] package/libglib2: fix libiconv (intl) support Thomas Devoogdt
2024-02-07 16:10 ` Thomas Petazzoni via buildroot
2024-03-01 10:52 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q8u9qbl.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox