From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libmemcached: force CMAKE_BUILD_TYPE
Date: Mon, 13 Nov 2023 19:54:28 +0100 [thread overview]
Message-ID: <871qctfpqz.fsf@48ers.dk> (raw)
In-Reply-To: <87cywfglvx.fsf@48ers.dk> (Peter Korsgaard's message of "Sun, 12 Nov 2023 14:08:02 +0100")
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>> Force CMAKE_BUILD_TYPE to Release to avoid the following build failure
>> with c-icap or php-memcached raised since bump to version 1.1.4 and
>> switch to cmake-package in commit
>> 7205df8a4f3c729b11a5f0c34885e6cf592f24b9:
>> Fixes:
>> - http://autobuild.buildroot.org/results/bca84915550a72f1dc89c8661cba2545d6bc96ef
>> - http://autobuild.buildroot.org/results/b140d225208e7fa44b935a119e74347caf710e55
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/libmemcached/libmemcached.mk | 4 ++++
>> 1 file changed, 4 insertions(+)
>> diff --git a/package/libmemcached/libmemcached.mk b/package/libmemcached/libmemcached.mk
>> index bd63d78c97..2c268d4151 100644
>> --- a/package/libmemcached/libmemcached.mk
>> +++ b/package/libmemcached/libmemcached.mk
>> @@ -14,6 +14,10 @@ LIBMEMCACHED_LICENSE = BSD-3-Clause
>> LIBMEMCACHED_LICENSE_FILES = LICENSE
>> LIBMEMCACHED_CPE_ID_VENDOR = awesome
>> +# Force Release otherwise libraries will be suffixed by -dbg which will raise
>> +# unexpected build failures with packages that use libmemcached (e.g. c-icap)
>> +LIBMEMCACHED_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
>> +
> As correctly warned by check-package:
> Applying: package/libmemcached: force CMAKE_BUILD_TYPE
> gpackage/libmemcached/libmemcached.mk:19: unconditional override of variable LIBMEMCACHED_CONF_OPTS
> _CONF_OPTS already get set in line 10, so I changed this to be += and
> applied, thanks.
Committed to 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-13 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 20:36 [Buildroot] [PATCH 1/1] package/libmemcached: force CMAKE_BUILD_TYPE Fabrice Fontaine
2023-11-12 13:08 ` Peter Korsgaard
2023-11-13 18:54 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qctfpqz.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox